[IE] Wrong find matching in IE8 quirks

[Tobiasz Cudnik]

Wrong find matching in IE8 quirks.

TC

1. Use following content:

   <p>
   	^a foo a</p>
   <p>
   	a foo a</p>
   <p>
   	&nbsp;</p>
   
   

2. Open Find dialog
3. Search for "foo"

Result:

<p>
	a ^foo a^</p>
<p>
	a foo a</p>
<p>
	&nbsp;</p>

Expected result:

<p>
	a ^foo^ a</p>
<p>
	a foo a</p>
<p>
	&nbsp;</p>

Does not take place in IE8 strict.

[Garry Yao]

As discussed with Tobias, I'll take over this ticket to avoid overlapping at several recent related tickets.

[Garry Yao]

This is an uncovered case of #3436, yet another browser sniffing mistake, the culprit is that the detection result of CKEDITOR.env.version == 7 under IE8 quirk will skip the fix for CKEDITOR.dom.text::splitText.
The idea fix should use feature detection instead.

[Martin Kou]

Good job.

[Alfonso Martínez de Lizarrondo]

Warning: that trick to detect IE8 isn't safe.

in Firefox 3.5

Object.prototype.toString.call( self.JSON )  !=  "[object JSON]"

is false, so it will follow the IE8 code path although it doesn't needs it. As other browsers implement native JSON support they will also fail the test

[Martin Kou]

Oh, you're right, I haven't considered that.

[Frederico Caldeira Knabben]

CKEDITOR.env should support all our browser detection needs.

[Garry Yao]

Proposing a better way to detect this feature and centralize it into CKEDITOR.env.

[Martin Kou]

The new detection method is more accurate for sure, but I'm not sure if the increased core code size is worth it.

[Frederico Caldeira Knabben]

That's correct. We don't need to bloat CKEDITOR.env. It "already" offers all we need, and for this case, it's enough to check for IE8 inside the spli function. My previous concerns were about using the JSON object for detection.

This fix must be as simple as possible, and even the newly proposed detection system can be simplified.

[Garry Yao]

I've reverted the detect to browser sniffing way, which include part of Tobiasz's approach at #3549 here for detecting ie8 with documentMode.

[Garry Yao]

Fixed with [3509].