[IE8] Empty dropdowns

[ppx]

IE8's compatibility mode there is no problem, but not in compatibility mode button will be under the font settings problem

[Tobiasz Cudnik]

I confirm that issue exists in following modes:

• IE8 in IE7 strict mode
• IE8 in quirks mode
• IE8 compatibility in IE8 strict mode

[Tobiasz Cudnik]

IE8 seems to add strange .null_container class to iframe's html element. This patch overloads visibility property from this class using inline style.

[Tobiasz Cudnik]

Problem seem to be created in _source/plugins/panel/plugin.js L132 and this workaround is unnecessary.

[Tobiasz Cudnik]

The real problem was with CKEDITOR.dom.element.getAttribute function and it's IE workarounds.

I've introduced new env.ie7Compat property and changed env.ie8 to reflect usage of IE8 independently from compatibility mode.

Patch fixes this issue but can create new issues in places depending on env.ie8, although i haven't found any.

[Tobiasz Cudnik]

I'm proposing yet another patch with alternative approach for all IE versions, which doesn't need modifications in env object. Although i'm not sure if it's better then second one.

[Garry Yao]

The patch failed the following TCs for element.html on IE8 standard mode.

• test_setAttribute1,2
• test_setAttributes
• test_removeClass1,2

[Garry Yao]

Besides,it's better to avoid using guard with dom attributes result, since falsy values e.g. "" or 0 are also possible results.

   return this.$[ name ] || standard.call( this, name );

[Tobiasz Cudnik]

Although none of failed tests was related to the patch itself and was failing also without it i've prepared wider patch for element.js which passes element.html in all IE8 variations (there are 8 of them).

I could have some doubts about test itself, because it expects case-insensitive class names, which isn't fully correct.

[Frederico Caldeira Knabben]

The changes are good, but it looks like they are not needed in IE8 standards mode. So, it would be better to not force the IE workarounds for that case.

[Tobiasz Cudnik]

5th patch fixes issue using IE8 API when possible and fallbacks only when needed. It was possible to achieve using changes from [3537].

Dropdown content is visible on IE8 modes.

[Garry Yao]

Do you think:

( !CKEDITOR.env.ie8 || CKEDITOR.env.ie7Compat || CKEDITOR.env.ie6Compat )

is same as:

( CKEDITOR.env.ie7Compat || CKEDITOR.env.ie6Compat )

[Tobiasz Cudnik]

Actually yes, thats true. ie7Compat and ie6Compat are not IE8-only flags, so env.ie8 can be omitted.

[Garry Yao]

Please make sure the patch trunk contains BOM is removed when committing.

[Garry Yao]

And, very important, though not related to this specific tickets, please have the setAttribute fixed in the same way also.

[Tobiasz Cudnik]

Fixed with [3625]. element.html test failes moved to #3679.