Opened 10 years ago

Closed 10 years ago

#3581 closed Bug (fixed)

name attribute on anchors is duplicated

Reported by: Alfonso Martínez de Lizarrondo Owned by: Artur Formella
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Cc:

Description (last modified by Alfonso Martínez de Lizarrondo)

Load CKEditor and insert an anchor. Put any name on it.

Switch to source mode, everything looks OK.

<p>
	This<a name="test"></a> is some <strong>sample text</strong>. 
You are using <a href="http://www.fckeditor.net/">CKEditor</a>.</p>

Switch to design and back to source, the anchor now has two name attributes

<p>
	This<a name="test" name="test"></a> is some <strong>sample text</strong>. 
You are using <a href="http://www.fckeditor.net/">CKEditor</a>.</p>

Attachments (1)

3581.patch (676 bytes) - added by Artur Formella 10 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Description: modified (diff)

comment:2 Changed 10 years ago by Artur Formella

Keywords: Confirmed added
Milestone: CKEditor 3.0

comment:3 Changed 10 years ago by Frederico Caldeira Knabben

Owner: set to Artur Formella

Changed 10 years ago by Artur Formella

Attachment: 3581.patch added

comment:4 Changed 10 years ago by Artur Formella

Keywords: Review? added

The same problem was with images.

comment:5 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review- added; Review? removed

The fix for links is ok, but I don't see how it's possible to add a name attribute to the images.

I don't even remember if it's valid or people should use only IDs for images, and use name only for form elements and anchors as legacy (they should be IDs for compatibility with xhtml 1.1)

comment:6 in reply to:  5 Changed 10 years ago by Artur Formella

I have found "name" on http://www.w3.org/TR/REC-html40/struct/objects.html

Please insert in source mode:

<p>
	<img name="test" /> </p>

Switch do WYSIWYG and back to Source. Result:

<p>
	<img name="test" name="test" /> </p>

It is not the expected behavior.

comment:7 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review+ added; Review- removed

Right, even if the interface doesn't allow to change it, the code should work correctly

comment:8 Changed 10 years ago by Artur Formella

Resolution: fixed
Status: newclosed

Fixed with [3598]

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy