IE: switching to Source in Ajax example raises an error

[Alfonso Martínez de Lizarrondo]

Load the Ajax sample in IE, switch to source mode and it raises an error.

The Image() method of the undo system is called twice and the second time editor.getSnapshot() returns false.

[Garry Yao]

A more simple fix would be found, as now we're saving snapshot for many commands which doesn't make sense for supporting undo, these are:

1. Preview
2. Copy
3. Spell Check
4. Find/Replace ( Each replacing is needing one, but not the dialog command )
5. Select All
6. Maximize
7. Show Block
8. About

We should give them a canUndo = false instead of introducing other specific flag.

[Martin Kou]

Hmm... actually the undo systems seems broken in respect to editor mode changes. With the trunk, even if I've set canUndo to false - after switch to Source and back, I would have about 4 undo steps in the system. Some of them even have an extra empty paragraph before the first paragraph.

[Artur Formella]

Saving snapshot before Source could make sense - this should be checked. Saving snapshot in other dialog aren't connected with the main issue - moved to #3621

[Martin Kou]

It makes sense to save an undo snapshot when switching from Source to WYSIWYG mode - the document contents might have changed during Source mode. So if we just set canUndo = false the result would be wrong.

However, because editor.getSnapshot() might return null right after the Source command is executed, it doesn't make sense to save a snapshot right after Source command is invoked.

So, instead of saving snapshot at Source command invocation - we can save the snapshot whenever the editor mode has switched to WYSIWYG. This avoids the null error while still manages to save a snapshot if editor content is changed in Source mode.

[Artur Formella]

Image is saved only when switching back to WYSIWYG so some undo information are lost.

I found one bug with this patch - steps to reproduce:

-Click "Create Editor"
-Write aaaaaa
-Go to Source mode
-Write bbbbbb
-Back to WYSIWYG
-Click Undo

Result: Editor is empty.
Expected result: aaaaaa in the editor.

To save image why not just add

if ( editor.mode == 'wysiwyg' )
	editor.fire( 'saveSnapshot' );

in source.exec() before setMode(...)

[Martin Kou]

Fixed with [3599].

Click here for more info about our SVN system.