Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#3660 closed New Feature (fixed)

Add separate NAME parameter in taglib

Reported by: David Webb Owned by:
Priority: Normal Milestone: FCKeditor.Java 2.6
Component: Server : Java Version:
Keywords: Java Taglib Review+ Cc: David Webb

Description (last modified by Michael Osipov)

Add the ability to create a NAME parameter in the FCKEditor Taglib in addition to the instanceName (which is the ID and NAME currently).

I am attaching the patches for the TLD and the 2 java files that need modofication for this feature.

Reference Topic: [http://www.fckeditor.net/forums/viewtopic.php?f=5&t=14048&p=36740#p36740 ]

Attachments (2)

3660.patch (5.6 KB) - added by David Webb 10 years ago.
3660_2.patch (9.0 KB) - added by Michael Osipov 9 years ago.
Modification of the first patch

Download all attachments as: .zip

Change History (12)

comment:1 Changed 10 years ago by Michael Osipov

Please attach the patch as-is and do not compress in with proprietary formats. See here for more information.

comment:2 Changed 10 years ago by David Webb

Keywords: Review? added; Java Taglib removed

comment:3 Changed 10 years ago by David Webb

Keywords: Java Taglib added

My bad on the individual patches...Uploading 3660.patch which will include all 3 files. You can delete all other attachments if you want to. Thanks.

Changed 10 years ago by David Webb

Attachment: 3660.patch added

comment:4 Changed 10 years ago by Michael Osipov

I will review the ticket after documentation completion!

comment:5 Changed 10 years ago by Michael Osipov

Please try the newest 2.5-beta-1 release. You can define your own connector which should provide the option you are looking for.

comment:6 Changed 10 years ago by Michael Osipov

Sorry, completely wrong ticket.

comment:7 Changed 9 years ago by Michael Osipov

Keywords: Review- added; Review? removed
Milestone: FCKeditor.Java 2.6

Counter is not thread-safe. This will emerge in 2.6 in a slightly modified version.

comment:8 Changed 9 years ago by Michael Osipov

Description: modified (diff)
Status: newassigned

Changed 9 years ago by Michael Osipov

Attachment: 3660_2.patch added

Modification of the first patch

comment:9 Changed 9 years ago by Michael Osipov

Keywords: Review+ added; Review- removed
Resolution: fixed
Status: assignedclosed

Modified patch applied in [4598].

comment:10 Changed 9 years ago by Michael Osipov

Description: modified (diff)

The auto-id function was not applied because the original patch was not thread-safe and it's not that valueable for the vast majority to impose synchronization.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy