Opened 10 years ago

Closed 10 years ago

#3659 closed Bug (fixed)

newpage undo problem

Reported by: Garry Yao Owned by: Garry Yao
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: Core : Undo & Redo Version:
Keywords: Confirmed Review+ Doc Cc:

Description

Reproducing Procedures

  1. Open the replace by class example page in FF;
  2. Click 'New Page' to empty document;
  3. Press 'Undo' button;
    • Expected Result: The original document has been reverted.
    • Actual Result: The document remains empty, and actually you need two more 'Undo' to revert it back.

Attachments (1)

3659.patch (2.5 KB) - added by Garry Yao 10 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

The problem with 'New Page' command is it's sort of asynchronized command that we can 't fire 'afterCommandExec' immediately, if that, the snapshot is been taken even when document content is not loaded.

Changed 10 years ago by Garry Yao

Attachment: 3659.patch added

comment:2 Changed 10 years ago by Garry Yao

Keywords: Review? added

The patch is about supporting asynchronous command, say, now first on 'New Page'.

comment:3 Changed 10 years ago by Artur Formella

Keywords: Review+ added; Review? removed

comment:4 Changed 10 years ago by Artur Formella

Keywords: Doc? added

comment:5 Changed 10 years ago by Alfonso Martínez de Lizarrondo

I didn't look at this part still, but this is one part that I think it would be better if it can be changed from V2 (people has lots of problems with it)

The question is: does the SetHTML really needs to be asynchronous? Can't we work directly with the existing document when the user wants to change it instead of being forced to create a new one?

If the answer is maybe, then I think that this patch shouldn't be applied (at least for the moment), and a new ticket to change SetHTML (or its current equivalent) to make it synchronous should be open.

What do you think?

comment:6 Changed 10 years ago by Garry Yao

yes, alfonsoml, this should be put discusssion, but it's not a little change, and I guess the major problem without reload the iframe is about the stylesheet, when 'New Page' is asked, ideally we should has a clean document or I am wrong?

comment:7 Changed 10 years ago by Artur Formella

Currently this code doesn't work after istanceReady event:

editor.setData("aa");
b= editor.getData();

It would be great to work with the existing document, but it would be too big change for beta version. I thing we should open a new ticket for discussion.

comment:8 Changed 10 years ago by Garry Yao

Priority: NormalHigh

comment:9 Changed 10 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

I'm closing this one and opening #3732 for discuss alfonsoml's proposal.
Fixed with [3668].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy