Opened 9 years ago

Closed 9 years ago

#3768 closed Bug (fixed)

SCAYT setting must not use an object tree

Reported by: Frederico Caldeira Knabben Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.0
Component: UI : Spell Checker Version: SVN (CKEditor) - OLD
Keywords: Confirmed 3.0RC Review+ Cc: WebSpellChecker.net

Description

[3696] changed the scayt plugin specific settings to be based on a main configuration object called CKEDITOR.config.scaytParams. As discussed in the past, this approach is wrong, as it makes it difficult to override settings in the config.js file.

Single level settings names should be used, prefixed with the plugin name, like scayt_maxSuggestions and scayt_autoStartup.

Attachments (1)

3768.patch (1.5 KB) - added by Frederico Caldeira Knabben 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by Frederico Caldeira Knabben

Attachment: 3768.patch added

comment:1 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: 3.0RC Review? added
Status: newassigned

I'm not removing CKEDITOR.config.scaytParams to avoid breaking things. I'm just fixing the ticket issues here.

comment:2 Changed 9 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:3 Changed 9 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Fixed with [3703].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy