Combine skin images

[Frederico Caldeira Knabben]

Some skin images could be combined inside sprites.png, reducing the number of HTTP calls.

Currently, the following could be considered:

• arrowdown.gif
• arrowtop.gif
• arrowleft.gif
• arrowright.gif
• resizer.gif
• resizer_rtl.gif

[Tobiasz Cudnik]

Binary files.

[Frederico Caldeira Knabben]

It's almost perfect. Just the following small issues:

• The arrow for the toolbar collapser is 2px mispositioned in RTL. I've noted that you have used background position 4px for LTR, but 2px for RTL. Maybe using also 4px will fix the problem.

• IE+RTL: The context menu arrow is at right.

• IE6: The context menu arrow shows white background when rollover.

I'm adding an attachment with screenshot for all the above.

[Tobiasz Cudnik]

I've managed to fix all 3 mentioned issues plus others below:

• office2003 dialogs lacked vertical shadow in RTL
• propagated fix from #3969 in office2003 and v2 skins which turned out to be also affected
• fixed office2003 and v2 context menu in RTL
• fixed downarrows in office2003

[Tobiasz Cudnik]

Instead of #3969 i've meant #3696.

[Frederico Caldeira Knabben]

I've followed the following steps:

1. Applied 3793_3.patch into my updated local trunk copy.
2. Overwritten my local copy files with all files available at skins_3.zip.

Then, while testing, I've noticed that none of the issues described in my previous comment have been addressed.

Locking closer to the patch, it looks like things have been fixed, but much probably the skins_3.zip file is wrong. so, it was not possible to properly test the fix.

Ideally the skins_3.zip should contain only the binary files that the patch can't have, or even the full directories copy, but including the properly patched files.

[Tobiasz Cudnik]

skins_3.zip was supposed to provide only binary files, although it contained also normal css files from previous patch, what created the confusion.

I will prepare new zip packages for easier testing.

[Frederico Caldeira Knabben]

I've overwritten my local copy with skins_all_4.zip and the layout got totally broken in IE. In Firefox it's also possible to note issues when collapsing the toolbar.

[Frederico Caldeira Knabben]

It looks like things where broken because skins_all_4.zip is not good for it. The right way is instead having the latest patch plus skins_binary_4.zip.

[Frederico Caldeira Knabben]

Everything looks good, except a rendering issue in the toolbar arrows with IE7+Standards.

[Tobiasz Cudnik]

Patch commited with [3890] in ​features/3793 branch.

IE7 standard incorrectly handles alpha transparency in backgrounds when element itself is filtered with alpha transparency.

[Frederico Caldeira Knabben]

The Kama skin looks good. There are issues with the Office2003 skin, with IE+Quirks and IE6.

• The dialog shadow is broken and not properly rendered (no support for PNG transparency)

• The dialog close button is mispositioned.

I'll be attaching a screenshot illustrating it in IE7. The same problems can be see in IE6, no matter the mode.

[Frederico Caldeira Knabben]

IE7 screenshot of branches/features/3793 at r3894.

[Frederico Caldeira Knabben]

Regarding the dialog shadow, the current trunk behavior is the expected one, having no shadow at all in IE+Quirks and IE6.

[Tobiasz Cudnik]

Changeset [3896] address issue you've mentioned. Attaching screenshots.

[Tobiasz Cudnik]

IE8

[Tobiasz Cudnik]

IE7

[Tobiasz Cudnik]

IE6

[Frederico Caldeira Knabben]

I've partially reverted [3896] and properly fixed the close button position with [3905].

[Frederico Caldeira Knabben]

I've also fixed the dialog borders in the office2003 skin for IE+Quirks+RTL with [3906].

Now, the V2 skin is broken isntead.

[Tobiasz Cudnik]

Review? for [3907].

[Frederico Caldeira Knabben]

Kama: IE+Quirks: The Button Panel items in the toolbar (color selectors and SCAYT) have no arrows anymore.

[Tobiasz Cudnik]

Review? for [3921].

[Frederico Caldeira Knabben]

I have made a small fix for v2 with [3923]. Things should be ok now... finally!

[Tobiasz Cudnik]

Fixed with [3927] and [3928].