[webkit] Color button panel incorrect size on first open

[Garry Yao]

Reproducing Procedures

1. Open the replace by class example page with Safari;
2. Click on 'Font Color' button to open panel;
   • Actual Result: The panel size is shrinked.
3. Click again.
   • Actual Result: Now the panel size is correct.

[Garry Yao]

Screenshot of Safari4

[Tobiasz Cudnik]

Affected are:

• Chrome 2
• Chrome 3
• Safari 3
• Safari 4

It's a bit random to reproduce, but it's easiest in case of Chrome 2.

[Tobiasz Cudnik]

Patch fixes block.autoSize in floatPanel on webkits and should work always, under one condition - first child have to be at least 1px height.

[Garry Yao]

The patch works, but the polling might not be considered, it seems for me a '100ms' fixed delay when joining the IE fix on L218:

// IE7 needs some time (setting the delay to 0ms won't work) to refresh
// the scrollHeight. (#3174)
if ( CKEDITOR.env.ie && CKEDITOR.env.version >= 7 || CKEDITOR.env.webkit )
	setTimeout( setHeight, 100 );

[Tobiasz Cudnik]

Single delay doesn't resolve issue fully, tried that at first. Long delay will work, but in most cases it will be unnecessary long.

Why do you think that "polling might not be considered" ?

[Garry Yao]

As discussed with Tobiasz, we could try to wait the panel frame fully loaded before the 'showBlock' logic, which will hopefully resolve the issue without a polling or a waiting.

[Tobiasz Cudnik]

It turns out that panels already provide onLoad function, which is even used for setHeight, but only for Gecko browsers. This is most probably because IE's problem with window.onLoad.

I've fixed IE onLoad (using body) and merged code for all browsers to use setHeight fired by onLoad. This fixes colorbutton issue.

Tests in all browsers available in screenshots.

[Garry Yao]

Nice patch, at this fix we also avoid the risk of finished the document loading before attach the listener.

[Tobiasz Cudnik]

Fixed with [3843].

[Frederico Caldeira Knabben]

I've reverted [3843] with [3853] because the second level menu became broken after it (at least with IE7).

[Tobiasz Cudnik]

IE had some issue with CKEDITOR var assigment inside iframe's window when it was moved before document open & write & close. When this assigment was after that, it works.

I've tested on IE 6, 7, 8 using SCAYT suggestions and table context menus (second levels).

[Tobiasz Cudnik]

Fourth patch fixes IE's onload handler when editor nested in an iframe.

[Tobiasz Cudnik]

Fixed with [3893].