Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3878 closed New Feature (fixed)

Image pop-up have scrollbars

Reported by: kinguru Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: 3.0 RC
Keywords: Confirmed Review+ Cc:

Description

Not all content fits to window of image pop-up. It happens in russian language.

I think, you must dynamically determine window desired size after all content are rendered.

Attachments (6)

3878.patch (19.6 KB) - added by Artur Formella 8 years ago.
3878_2_test.patch (30.3 KB) - added by Artur Formella 8 years ago.
3878_2.patch (13.4 KB) - added by Artur Formella 8 years ago.
3878_3.patch (2.1 KB) - added by Frederico Caldeira Knabben 8 years ago.
3878_FF3.jpg (36.2 KB) - added by Artur Formella 8 years ago.
3878_4.patch (2.6 KB) - added by Frederico Caldeira Knabben 8 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 Changed 8 years ago by Artur Formella

Keywords: Confirmed added
Owner: set to Artur Formella
Status: newassigned

The same problem with french language.

Changed 8 years ago by Artur Formella

Attachment: 3878.patch added

comment:2 Changed 8 years ago by Artur Formella

Keywords: Review? added

Now there is possible to break line in very long translation. Improved also image and link dialog.

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

I understand the idea behind the patch, but the method is wrong. We must not have UI related solutions into the language files. We must have only text there, which could be used for any need. For example, the dialog layout could be changed to another solution where the label size has no impact. We should not make translation changes at that point.

If we want words to break in our layout, we should instead set fixed sizes to the labels spaces in the dialog definition, so the browser will force line breaks by itself.

Another solution, and the one I would take here, would be simply changing the dialog layout a bit, moving the labels to be place above the fields, instead of aside of them.

Changed 8 years ago by Artur Formella

Attachment: 3878_2_test.patch added

Changed 8 years ago by Artur Formella

Attachment: 3878_2.patch added

comment:4 Changed 8 years ago by Artur Formella

Keywords: Review? added; Review- removed

comment:5 Changed 8 years ago by Frederico Caldeira Knabben

Owner: changed from Artur Formella to Frederico Caldeira Knabben
Status: assignednew

We still have issues with the layout, being now rendered wrongly in some cases (like the "Advanced" tab in the Link dialog with IE).

Anyway, we should not propose any huge change at this phase. We'll work on better solutions in the future. I'll propose a simple patch that at least minimizes this issue in some browsers.

Changed 8 years ago by Frederico Caldeira Knabben

Attachment: 3878_3.patch added

comment:6 Changed 8 years ago by Frederico Caldeira Knabben

Status: newassigned

This is a quick fix for this issue, for all browsers but IE. We should have a new ticket for IE only right after committing this one. We'll deal with it in a future release.

comment:7 Changed 8 years ago by Artur Formella

Keywords: Review- added; Review? removed

Paste from Word dialog has wrong layout.

Changed 8 years ago by Artur Formella

Attachment: 3878_FF3.jpg added

Changed 8 years ago by Frederico Caldeira Knabben

Attachment: 3878_4.patch added

comment:8 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed

comment:9 Changed 8 years ago by Artur Formella

Keywords: Review+ added; Review? removed

comment:10 Changed 8 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Fixed with [3900].

comment:11 Changed 8 years ago by Frederico Caldeira Knabben

#4128 has been marked as DUP.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy