Opened 8 years ago

Closed 8 years ago

#3897 closed Bug (fixed)

There should be no image previews when the URL is empty in image dialog

Reported by: Martin Kou Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.1
Component: UI : Dialogs Version: SVN (CKEditor) - OLD
Keywords: Oracle Confirmed Review+ Cc: Senthil

Description

To reproduce:

  1. Open replacebyclass sample in IE.
  2. Open the image dialog.
  3. Even before any URL is filled into the dialog box, we're still having a cross symbol in the preview pane.

Or, alternatively

  1. Open replacebyclass sample in any browser.
  2. Open the image dialog.
  3. Fill in any URL and defocus the URL text box.
  4. Remove the URL
  5. The image is still in the preview pane - it should be cleared instead.

Attachments (3)

3897.patch (1.2 KB) - added by Tobiasz Cudnik 8 years ago.
3897_2.patch (2.0 KB) - added by Tobiasz Cudnik 8 years ago.
3897_3.patch (2.0 KB) - added by Tobiasz Cudnik 8 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 8 years ago by Martin Kou

Cc: Senthil added
Keywords: Oracle added

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.0CKEditor 3.1

comment:3 Changed 8 years ago by Tobiasz Cudnik

Owner: changed from Martin Kou to Tobiasz Cudnik
Status: newassigned

Changed 8 years ago by Tobiasz Cudnik

Attachment: 3897.patch added

comment:4 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review? Confirmed added

comment:5 Changed 8 years ago by Garry Yao

Keywords: Review- added; Review? removed

It doesn't work for IE.

Changed 8 years ago by Tobiasz Cudnik

Attachment: 3897_2.patch added

comment:6 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review? added; Review- removed

Seem that setAttribute( 'name', null ) doesn't work like removeAttribute( 'name' ) in IE, while doing so in other browsers.

comment:7 Changed 8 years ago by Garry Yao

How about using the below codes after #3898's fix?

if( this.getContentElement( 'info', 'txtUrl' ).validate() != true )
// instead of
if ( !CKEDITOR.tools.trim( this.getValueOf( 'info', 'txtUrl' ) ) )

comment:8 Changed 8 years ago by Garry Yao

Keywords: Review- added; Review? removed

comment:9 Changed 8 years ago by Tobiasz Cudnik

Using validate() doesn't work for first dialog show, while getValueOf() is not affected. I will check why that is happening.

Changed 8 years ago by Tobiasz Cudnik

Attachment: 3897_3.patch added

comment:10 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review? added; Review- removed

After updating dialog file to newer revision it indeed works. Attaching new patch.

comment:11 Changed 8 years ago by Garry Yao

Keywords: Review+ added; Review? removed

R+ for 3897_2, 3897_3 instead will bring a validation alert which is not acceptable.

comment:12 Changed 8 years ago by Tobiasz Cudnik

Resolution: fixed
Status: assignedclosed

Fixed with [4179].

In future will can use 3897_3.patch, when dialog validation system will allow for it.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy