Opened 8 years ago

Closed 8 years ago

#3898 closed Bug (fixed)

Add validation checks to image properties dialog.

Reported by: Martin Kou Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.1
Component: UI : Dialogs Version: SVN (CKEditor) - OLD
Keywords: Oracle Confirmed Review+ Cc: Senthil

Description

To reproduce:

  1. Open the image dialog.
  2. Press OK.

An image with no src is created. This is not really a critical issue, but it's reasonable to have some validation there.

Attachments (3)

3898.patch (42.2 KB) - added by Tobiasz Cudnik 8 years ago.
3898_2.patch (41.5 KB) - added by Tobiasz Cudnik 8 years ago.
3898_3.patch (41.3 KB) - added by Tobiasz Cudnik 8 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.0CKEditor 3.1

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

#4004 has been marked as DUP.

comment:3 Changed 8 years ago by Tobiasz Cudnik

Owner: changed from Martin Kou to Tobiasz Cudnik
Status: newassigned

Changed 8 years ago by Tobiasz Cudnik

Attachment: 3898.patch added

comment:4 Changed 8 years ago by Tobiasz Cudnik

Keywords: Confirmed Review? added

comment:5 Changed 8 years ago by Garry Yao

Keywords: Review- added; Review? removed

We've already have validation system for dialog, please check link dialog for using it.

comment:6 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review? added; Review- removed

Thanks for the hint, second patch uses validate() method from dialog system.

Changed 8 years ago by Tobiasz Cudnik

Attachment: 3898_2.patch added

comment:7 Changed 8 years ago by Garry Yao

Keywords: Review- added; Review? removed

My fault, link dialog isn't an decent example for it, the validation is as simple as :

validate : CKEDITOR.dialog.validate.notEmpty( editor.lang.image.urlMissing )

Changed 8 years ago by Tobiasz Cudnik

Attachment: 3898_3.patch added

comment:8 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review? added; Review- removed

Will memorize this one for the future.

comment:9 Changed 8 years ago by Garry Yao

Keywords: Review+ added; Review? removed

Please correct the changelog position when committing.

comment:10 Changed 8 years ago by Tobiasz Cudnik

Resolution: fixed
Status: assignedclosed

Fixed with [4130].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy