Opened 13 years ago

Closed 13 years ago

#39 closed Bug (fixed)

Firefox: submenus in tables doesn't close on selection

Reported by: Alfonso Martínez de Lizarrondo Owned by:
Priority: Must have (possibly next milestone) Milestone: FCKeditor 2.4
Component: General Version:
Keywords: Cc:

Description

This is a regression as 2.3.2 works fine: put a table and bring up the context menu to delete a column, click it and the column goes away as well as the main menu, but the submenu with options about columns (or rows ) remains on screen.

I've hunted it down to revision 97 in sourceforge, more exactly to this addition in FCKEditingArea.prototype.Focus :

			if ( this.Document.hasFocus() )
				return ;

As the log for that revision said that it was to fix a problem in IE I've changed to

			if ( FCKBrowserInfo.IsIE && this.Document.hasFocus() )
				return ;

and now the submenu goes away in firefox.

Change History (2)

comment:1 Changed 13 years ago by Frederico Caldeira Knabben

Milestone: FCKeditor 2.4
Priority: NormalHigh

This is a important fix. Go ahead with the trunk.

That code was fixing a bug with IE in a very specific case. I believe your fix will have no negative impact.

comment:2 Changed 13 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: newclosed

merged in revision 61

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy