Opened 10 years ago

Last modified 9 years ago

#3934 review_failed Bug

New line collapsed in enterMode=BR

Reported by: Garry Yao Owned by:
Priority: Normal Milestone:
Component: General Version:
Keywords: Firefox Cc:

Description

Reproducing Procedures

  1. Open the attached example page in Firefox.
  2. Move the cursor at the end of first line, press 'Enter'.
    • Actual Result: The new line is collapsed.

Attachments (2)

3934_TC.html (1.8 KB) - added by Garry Yao 10 years ago.
Sample page for reproducing
3934.patch (1.9 KB) - added by Tobiasz Cudnik 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by Garry Yao

Attachment: 3934_TC.html added

Sample page for reproducing

comment:1 Changed 10 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newassigned

Changed 10 years ago by Tobiasz Cudnik

Attachment: 3934.patch added

comment:2 Changed 10 years ago by Tobiasz Cudnik

Keywords: Confirmed Review? added

This patch splits BOM workaround for FF >= 3 (which isn't removed) and adds fake space for FF 2, as it's not affected by BOM fix.

Unfortunetelly space is still visible (on FF2) at end of line, but cursor position after enter is correct. Since it's rare character ('\u2007') it's possible to remove it in other place.

Correct me if my approach is wrong.

comment:3 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
Milestone: CKEditor 3.0CKEditor 3.x

Confirmed it with v2 also, with no drastic effect so far (not even a bug report). Postponing.

In any case, if you're supposed to leave garbage in the code, you should also propose the cleanup code for it.

comment:4 Changed 10 years ago by Tobiasz Cudnik

Owner: Tobiasz Cudnik deleted
Status: assignednew

comment:5 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x

Milestone CKEditor 3.x deleted

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy