Opened 8 years ago

Closed 7 years ago

#4082 closed Bug (fixed)

[IE+Quirks] Preview text in the image dialog is not wrapping

Reported by: Frederico Caldeira Knabben Owned by: Minh Nguyen
Priority: Normal Milestone: CKEditor 3.3
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed IE Review+ Cc:

Description

The preview text displayed in the Image dialog is not wrapping with IE7+Quirks.

Attachments (5)

4082.patch (1.4 KB) - added by Minh Nguyen 7 years ago.
4082_2.patch (1.9 KB) - added by Minh Nguyen 7 years ago.
4082_3.patch (2.0 KB) - added by Minh Nguyen 7 years ago.
4082_ref.patch (2.1 KB) - added by Garry Yao 7 years ago.
4082_5.patch (3.9 KB) - added by Minh Nguyen 7 years ago.
New approach

Download all attachments as: .zip

Change History (15)

Changed 7 years ago by Minh Nguyen

Attachment: 4082.patch added

comment:1 Changed 7 years ago by Minh Nguyen

Keywords: Review? added
Milestone: CKEditor 3.xCKEditor 3.3
Owner: set to Minh Nguyen
Status: newassigned

comment:2 Changed 7 years ago by Minh Nguyen

IE very interesting. I cannot explain why use '*' instead of '#ImagePreviewBox' in this case.

comment:3 Changed 7 years ago by Garry Yao

Keywords: Review- added; Review? removed

It works while make some of the dialog fields label wrapping incorrectly.
We should narrow down the selector if possible.

Changed 7 years ago by Minh Nguyen

Attachment: 4082_2.patch added

comment:4 Changed 7 years ago by Minh Nguyen

Keywords: Review? added; Review- removed

Changed 7 years ago by Minh Nguyen

Attachment: 4082_3.patch added

comment:5 Changed 7 years ago by Minh Nguyen

Keywords: Review- added; Review? removed

comment:6 Changed 7 years ago by Minh Nguyen

Keywords: Review? added; Review- removed

comment:7 Changed 7 years ago by Garry Yao

Keywords: Review- added; Review? removed

The latest patch is heading the correct way, while reset.css should only perform browser normalization instead of holding rules of a specific structure.
Providing a patch for reference.

Changed 7 years ago by Garry Yao

Attachment: 4082_ref.patch added

Changed 7 years ago by Minh Nguyen

Attachment: 4082_5.patch added

New approach

comment:8 Changed 7 years ago by Minh Nguyen

Keywords: Review? added; Review- removed

comment:9 Changed 7 years ago by Garry Yao

Keywords: Review+ added; Review? removed

It's a nice solution, table is highly welcomed by browsers in quirks :)

comment:10 Changed 7 years ago by Minh Nguyen

Resolution: fixed
Status: assignedclosed

Fixed with [5317].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy