Opened 16 years ago
Closed 16 years ago
#4117 closed Bug (fixed)
[IE] Transform image into imagebutton problem
Reported by: | Garry Yao | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | UI : Dialogs | Version: | |
Keywords: | IE Confirmed Review+ | Cc: |
Description
Reproducing Procedures
- Open the 'replace by class' sample page in IE;
- Load the document will following cotent and selection:
[<img alt="title" height="43" src="http://dev.fckeditor.net/chrome/site/logos.gif" width="207" />]
- Open 'Image Button' dialog and click 'OK';
- Actual Result: JavaScript error thrown.
Attachments (5)
Change History (17)
Changed 16 years ago by
Attachment: | 4117.patch added |
---|
comment:1 Changed 16 years ago by
Keywords: | Review? added |
---|---|
Status: | new → assigned |
comment:2 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
The changes lookg good. There is just a "debugger" line that has been left at line 311.
Changed 16 years ago by
Attachment: | 4117_2.patch added |
---|
comment:3 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
Beside the fix, another small change regard L288 of 4117.patch which should be routed into respected conditional block.
comment:5 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
The attempt to remove the link (by emptying the field) is not anymore working after the proposed patch.
Changed 16 years ago by
Attachment: | 4117_3.patch added |
---|
comment:6 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:7 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
With IE only, I'm having an error in the attempt to remove the link by cleaning the link URL field.
Changed 16 years ago by
Attachment: | 4117_4.patch added |
---|
comment:8 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
This lead us to a mistake within selection plugin, fixing it with other parts untouched.
comment:9 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
A console.log call has been left at line 343.
Changed 16 years ago by
Attachment: | 4117_5.patch added |
---|
comment:11 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
All the modification to document elements in dialog must obey the editor::insertElement rule in order to not break the selection in IE.