Opened 15 years ago
Closed 15 years ago
#4129 closed Bug (fixed)
[FF] Unable to remove list with Ctrl-A
Reported by: | Garry Yao | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | Core : Lists | Version: | |
Keywords: | Confirmed Review+ | Cc: |
Description
Reproducing Procedures
- Open the 'replace by class' sample page in Firefox;
- Load the document with the following content and selection with Ctrl-A:
[<p>line1</p> <p>line2</p>]
- Click on 'Insert/Remove Bulleted List' button twice;
- Actual Result: The second click of remove list has no effect.
Attachments (2)
Change History (9)
comment:1 Changed 15 years ago by
Keywords: | Confirmed added |
---|---|
Owner: | set to Tobiasz Cudnik |
Status: | new → assigned |
Changed 15 years ago by
Attachment: | 4129.patch added |
---|
comment:2 Changed 15 years ago by
Keywords: | Review? added |
---|---|
Owner: | changed from Tobiasz Cudnik to Garry Yao |
Status: | assigned → new |
comment:3 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|
Removing list works after second list-command with the patch, but after third one nothing is happening. Expected is that list will be created again.
comment:4 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|---|
Status: | new → assigned |
I'm trying to persuade that this patch's not being a drastic change:
- Changes in previous 4129.patch are leveraged without change.
- Changes to _source/plugins/wysiwygarea/plugin.js and _source/core/dom/element.js are because it's breaking the 'selectionChange' event
which stop the list command from freshing( Tobias's comment );
- Changes to _source/plugins/domiterator/plugin.js are necessary clean up to avoid extra list item ( contain only whitespace text ) been created when exec list command multiple times.
Changed 15 years ago by
Attachment: | 4129_2.patch added |
---|
comment:5 Changed 15 years ago by
I can confirm that issues i've mentioned is fixed with second patch.
comment:6 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
After discussing with Tobias, I'm taking over this ticket.