Opened 8 years ago

Closed 8 years ago

#4129 closed Bug (fixed)

[FF] Unable to remove list with Ctrl-A

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.0
Component: Core : Lists Version:
Keywords: Confirmed Review+ Cc:

Description

Reproducing Procedures

  1. Open the 'replace by class' sample page in Firefox;
  2. Load the document with the following content and selection with Ctrl-A:
    [<p>line1</p>
    <p>line2</p>]
    
  3. Click on 'Insert/Remove Bulleted List' button twice;
    • Actual Result: The second click of remove list has no effect.

Attachments (2)

4129.patch (2.8 KB) - added by Garry Yao 8 years ago.
4129_2.patch (5.4 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by Tobiasz Cudnik

Keywords: Confirmed added
Owner: set to Tobiasz Cudnik
Status: newassigned

Changed 8 years ago by Garry Yao

Attachment: 4129.patch added

comment:2 Changed 8 years ago by Garry Yao

Keywords: Review? added
Owner: changed from Tobiasz Cudnik to Garry Yao
Status: assignednew

After discussing with Tobias, I'm taking over this ticket.

comment:3 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review- added; Review? removed

Removing list works after second list-command with the patch, but after third one nothing is happening. Expected is that list will be created again.

comment:4 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed
Status: newassigned

I'm trying to persuade that this patch's not being a drastic change:

  1. Changes in previous 4129.patch are leveraged without change.
  2. Changes to _source/plugins/wysiwygarea/plugin.js and _source/core/dom/element.js are because it's breaking the 'selectionChange' event

which stop the list command from freshing( Tobias's comment );

  1. Changes to _source/plugins/domiterator/plugin.js are necessary clean up to avoid extra list item ( contain only whitespace text ) been created when exec list command multiple times.

Changed 8 years ago by Garry Yao

Attachment: 4129_2.patch added

comment:5 Changed 8 years ago by Tobiasz Cudnik

I can confirm that issues i've mentioned is fixed with second patch.

comment:6 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:7 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [4034].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy