Opened 8 years ago

Closed 8 years ago

#4245 closed Bug (fixed)

Template format error

Reported by: mike890 Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.1
Component: Core : Output Data Version: 3.0 RC
Keywords: Confirmed Review+ Cc:

Description

The second template named "Strange Template" generates a table with column width declared using the 'width' attribute. The FCK editor does not support this legacy attribute and uses the 'width' style instead. It would be great if you update the template and make it generate style="width:50%" instead of width="50%".

Attachments (2)

4245.patch (1.6 KB) - added by Garry Yao 8 years ago.
4245_2.patch (1.6 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by Garry Yao

Component: GeneralCore : Output Data
Keywords: Confirmed added; template removed
Milestone: CKEditor 3.1

comment:2 Changed 8 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

Changed 8 years ago by Garry Yao

Attachment: 4245.patch added

comment:3 Changed 8 years ago by Garry Yao

Keywords: Review? added

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
Summary: Template format error (very easy to fix. Will take just a few seconds)Template format error

We need to provide an output which is similar to the one that could be generated (and handled) by the editor. So, I'm ok with the "width" changes, but not for the "border".

Changed 8 years ago by Garry Yao

Attachment: 4245_2.patch added

comment:5 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:6 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

For consistency, please remove the semi-colon from the end of the style attributes values when committing.

comment:7 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [4353].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy