Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4272 closed Bug (fixed)

[IE] Kama skin toolbar broken in RTL+quirks

Reported by: Tobiasz Cudnik Owned by: Minh Nguyen
Priority: Normal Milestone: CKEditor 3.2
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed Kama IE Review+ Cc:

Description (last modified by Tobiasz Cudnik)

Kama skin toolbar broken in RTL+quirks. Refer to attached screenshot. Reproduced in IE8.

Attachments (5)

2009-08-21-133252_799x527_scrot.png (30.3 KB) - added by Tobiasz Cudnik 8 years ago.
config.js (824 bytes) - added by Tobiasz Cudnik 8 years ago.
4272.patch (1.1 KB) - added by Tobiasz Cudnik 8 years ago.
4272_2.patch (1.3 KB) - added by Minh Nguyen 8 years ago.
4272_3.patch (1.5 KB) - added by Minh Nguyen 8 years ago.

Download all attachments as: .zip

Change History (19)

Changed 8 years ago by Tobiasz Cudnik

comment:1 Changed 8 years ago by Tobiasz Cudnik

Description: modified (diff)
Keywords: IE added
Summary: Kama skin toolbar broken in RTL+quirks[IE] Kama skin toolbar broken in RTL+quirks

Changed 8 years ago by Tobiasz Cudnik

Attachment: config.js added

comment:2 Changed 8 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newassigned

Changed 8 years ago by Tobiasz Cudnik

Attachment: 4272.patch added

comment:3 Changed 8 years ago by Tobiasz Cudnik

Fix limited to IE quirks only. Tested on IE 6, 7, 8 and seems to work.

comment:4 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review? added

comment:5 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

This fix breaks the combo contents positioning. Confirmed in IE8 in LTR after patch.

comment:6 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.1CKEditor 3.2

comment:7 Changed 8 years ago by Tobiasz Cudnik

Owner: Tobiasz Cudnik deleted
Status: assignednew

comment:8 Changed 8 years ago by Minh Nguyen

RTL feature doesn't work in almost browser with version trunk.

Changed 8 years ago by Minh Nguyen

Attachment: 4272_2.patch added

comment:9 Changed 8 years ago by Minh Nguyen

Keywords: Review? added; Review- removed
Owner: set to Minh Nguyen
Status: newassigned

comment:10 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
  • As the name says, "contentsLangDirection" is related to the direction of the contents, not the UI. The UI instead is editor.lang.dir.
  • In any case, CSS for the UI must not go inline in the code, but in the skin CSS files. CSS selectors should be used to apply RTL specific style (.cke_rtl).

comment:11 Changed 8 years ago by Minh Nguyen

Keywords: Review? added; Review- removed

comment:12 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

Changed 8 years ago by Minh Nguyen

Attachment: 4272_3.patch added

comment:13 Changed 8 years ago by Minh Nguyen

Resolution: fixed
Status: assignedclosed

Fixed with [5110].

comment:14 Changed 8 years ago by Minh Nguyen

and [5112].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy