Opened 10 years ago

Closed 9 years ago

#4273 closed Bug (expired)

TD > UL > SPAN Causes FCKTableHandler.GetSelectedCells() to return nothing on right click

Reported by: Davey Shafik Owned by:
Priority: Normal Milestone:
Component: General Version: FCKeditor 2.4.3
Keywords: HasPatch Cc:

Description

This is an involved issue, so bear with me:

1) Create a table 2) Insert a List (UL or OL should trigger the issue) 3) Add some text to the list item, and style is using the Style drop down

You end up with something like:

<table>
    <tr>
       <td>
          <ul>
             <li><span style="color: red">Text</span></li>
          </ul>
       </td>
    </tr>
</table>

Then, right click on the span, and go to Cell > Cell Properties and try to set Horizontal Alignment to Right and click OK.

You end up with nothing being changed.

The reason is, FCKTableHandler.GetSelectedCells() at source:/FCKeditor/tags/2.6.4/editor/dialog/fck_tablecell.html#L38 returns no cells.

Attached is a patch to correct the issue.

Attachments (2)

fcktablehandler_gecko.js-select-bug.patch (706 bytes) - added by Davey Shafik 10 years ago.
fcktablehandler_gecko.js-select-bug-2.patch (740 bytes) - added by Davey Shafik 10 years ago.
Added missing semi-colon that breaks FCK when compressed

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by Davey Shafik

comment:1 Changed 10 years ago by Davey Shafik

I have an updated patch that works in more situations as sometimes the LI is passed in, sometimes the UL, or OL

Changed 10 years ago by Davey Shafik

Added missing semi-colon that breaks FCK when compressed

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: HasPatch WorksForMe added; **Firefox** removed
Milestone: FCKeditor 2.6.5

It works for me with FF 3.5. I have the impression that something is missing in the reproduction steps. Is it necessary to right click in any specific place to see the bug?

comment:3 Changed 9 years ago by Wiktor Walc

Resolution: expired
Status: pendingclosed

Please reopen this issue if this bug can be still reproduced in CKEditor 3.x.

Works for me:

<table>
	<tbody>
		<tr>
			<td style="text-align: right;">
				<ul>
					<li>
						<span style="color: red;">Text</span></li>
				</ul>
			</td>
		</tr>
	</tbody>
</table>
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy