Opened 8 years ago

Closed 8 years ago

#4341 closed New Feature (fixed)

Implement ShowBorders

Reported by: Alfonso Martínez de Lizarrondo Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: 3.0
Keywords: Confirmed Review+ Cc:

Description

Implement the ShowBorders feature.

Instead of being only a configuration option, I think that it would be much better if it was possible to use it as a command, so the people could opt to put it in the toolbar

Attachments (3)

4341.patch (4.4 KB) - added by Garry Yao 8 years ago.
4341_2.patch (6.1 KB) - added by Garry Yao 8 years ago.
4341_3.patch (6.1 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 8 years ago by Garry Yao

Keywords: Confirmed added
Owner: set to Garry Yao
Status: newassigned

Changed 8 years ago by Garry Yao

Attachment: 4341.patch added

comment:2 Changed 8 years ago by Garry Yao

Keywords: Review? added

Implement it as a command, and I'm currently disabled it in IE, with the concern of the implementation based on HTC would not accepted here. We may even considering a datafilter rule for IE.

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

It must also work with IE.

Also, the borderStyleRegex replacement is not necessary as we have it just once in the template.

comment:4 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

Manual TCs added at : http://ckeditor.t/tt/4341/1.html

Changed 8 years ago by Garry Yao

Attachment: 4341_2.patch added

comment:5 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
  • There should be no changes to the config.js file as those are plugin specific settings.
  • In any case, the effective code definition of startupShowBorders is not needed. It should be a "documentation only" definition, just like the dialog plugin settings.
  • What about IE6? If I can make it there (V2) I can make it everywhere, right?

Changed 8 years ago by Garry Yao

Attachment: 4341_3.patch added

comment:6 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

As discussed with Fred today, as we have almost complete control over the editor input, we could innovate a bit by simply using a css marker class for showborders style instead of the solution based on selectors and HTC before.
New Ticket Test added at :
http://ckeditor.t/tt/4341/2.html. http://ckeditor.t/tt/4341/3.html.

comment:7 Changed 8 years ago by Frederico Caldeira Knabben

#4735 has been marked as DUP.

comment:8 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

There is a typo in line 21 (an extra comma), which breaks the feature in IE6. Please fix it before committing.

comment:9 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Nice catch[[BR]] Fixed with [4568] and [4569].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy