Implement BrowserContextMenuOnCtrl

[Alfonso Martínez de Lizarrondo]

Port that setting from FCKeditor

[Frederico Caldeira Knabben]

• The browserContextMenuOnCtrl is plugin specific and should not be in config.js.

• In any case, it's not needed to declare the above config. It can be a "documentation only" thing, just like the dialog settings.

• The context menu plugin should be used in the future to activate context menus in other places, like when right clicking on element path tags to act over them, or even into the toolbar to customize it. So, it's better to not change it's signature to make it editor area specific. Other than that, the contextMenu class already receives the editor as a constructor parameter, so passing it to addTarget is redundant.

What about an additional parameter to addTarget, which tells whether to show the browser context menu on CTRL?

[Garry Yao]

Fixing the above mentioned issue and update the patch with #4530.

[Frederico Caldeira Knabben]

It's almost perfect. The only problem is that now you're not considering the default value associated to the setting. In this case, it's "true". In effect, the feature is not available by leaving the config file empty.

The pattern for that is the following, when retrieving the setting:

var browserContextMenuOnCtrl = editor.config.browserContextMenuOnCtrl;
browserContextMenuOnCtrl = ( typeof browserContextMenuOnCtrl == 'undefined' || browserContextMenuOnCtrl );

[Garry Yao]

Fixed with [4540].