Opened 8 years ago

Closed 6 years ago

#4345 closed New Feature (fixed)

Fire a "langLoaded" event after the languages have been loaded.

Reported by: Niek Kouwenberg Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.6.1
Component: UI : Language Version: 3.0
Keywords: HasPatch Cc:

Description

Currently almost every stage of the loading process will fire an event when completed, like "customConfigLoaded", "configLoaded", "pluginsLoaded".

Only the loadLang() method doesn't fire a "langLoaded" event, which might come in handy for custom language manipulation.

I want to add some custom translation-texts, and need to do it before my plugin loads. Since it is not (yet) possible to add these translations via the config (bug #1032), I want to use the "langLoaded" event.

Implementation is nothing more than adding one line:

144. editor.fire( 'langLoaded' );
145. loadPlugins( editor );

Attachments (2)

4345.patch (650 bytes) - added by Niek Kouwenberg 7 years ago.
Patch adding the proposed line + documentation at the bottom
4345_2.patch (853 bytes) - added by Frederico Caldeira Knabben 6 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by Niek Kouwenberg

Attachment: 4345.patch added

Patch adding the proposed line + documentation at the bottom

comment:1 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x

Milestone CKEditor 3.x deleted

comment:2 Changed 6 years ago by Sa'ar Zac Elias

Keywords: HasPatch added

Changed 6 years ago by Frederico Caldeira Knabben

Attachment: 4345_2.patch added

comment:3 Changed 6 years ago by Frederico Caldeira Knabben

Owner: set to Frederico Caldeira Knabben
Status: newreview

Nice tiny patch. I've updated it to the current trunk.

comment:4 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

Just change the documentation:
CKEDITOR#langLoaded => CKEDITOR.editor#langLoaded.

comment:5 Changed 6 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.6.1
Resolution: fixed
Status: review_passedclosed

Fixed with [6989].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy