Opened 15 years ago
Closed 14 years ago
#4358 closed New Feature (fixed)
List properties dialog box is missing
Reported by: | Wiktor Walc | Owned by: | Minh Nguyen |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.3 |
Component: | Core : Lists | Version: | SVN (CKEditor) - OLD |
Keywords: | Confirmed Review+ | Cc: | michel.denys@… |
Description
The properties for bulleted/numbered lists are missing (this feature is available in FCKeditor: when you click on a list, a "Bulleted List Properties" / "Numbered List Properties" item is available in the context menu).
The issue was reported here: http://cksource.com/forums/viewtopic.php?f=6&t=14342
Attachments (8)
Change History (33)
comment:1 Changed 15 years ago by
comment:2 Changed 15 years ago by
Component: | General → Core : Lists |
---|---|
Version: | → 3.0 |
Changed 15 years ago by
Attachment: | fck-list-properties.png added |
---|
comment:4 Changed 15 years ago by
Cc: | michel.denys@… added |
---|
comment:5 Changed 15 years ago by
Keywords: | Confirmed removed |
---|---|
Milestone: | CKEditor 3.1 → CKEditor 3.2 |
Version: | 3.0 → SVN (CKEditor) |
comment:6 Changed 15 years ago by
Milestone: | CKEditor 3.2 → CKEditor 3.3 |
---|
comment:7 Changed 15 years ago by
Possible workaround:
In the Style combo plugin (plugins\stylescombo\default.js), add an attribute for the ol element (or the ul element). For example, for roman lists:
CKEDITOR.addStylesSet('default',[ {name :'Roman',element:'ol',attributes:{type:'I'}}, ]);
It works BUT to apply the style, the ol element must be selected. The only method I saw is to select it via the name of the element shown at the bottom of the editor. Not very user friendly for casual users. (see the CKEDITOR FAQ http://cksource.com/forums/viewtopic.php?f=11&t=17301)
comment:8 Changed 15 years ago by
Keywords: | Confirmed added |
---|
Thanks kurgbe, we should be able to align this feature with v2 in this milestone, the styles combo is not sufficient to carry out this feature, we still need a classical dialog here.
comment:9 Changed 14 years ago by
Owner: | set to Minh Nguyen |
---|---|
Status: | new → assigned |
Changed 14 years ago by
Attachment: | liststyle_ref.zip added |
---|
Changed 14 years ago by
Attachment: | 4358.patch added |
---|
comment:10 Changed 14 years ago by
Keywords: | Review? added |
---|
comment:11 Changed 14 years ago by
Keywords: | Review- added; Review? removed |
---|
Alternate bulleted list type in IE doesn't work (it should be circle instead of "Circle"), besides, in V3 we should deprecate the "type" attribute in favor of list-style-type CSS property.
Also please use "<not set>" for unknown list type instead of leaving it empty.
Besides, Can we make the Bulleted List Type field a bit wider, make it looks better?
Changed 14 years ago by
Attachment: | 4358_2.patch added |
---|
comment:12 Changed 14 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:13 Changed 14 years ago by
Keywords: | Review- added; Review? removed |
---|
Please use "<not set>" instead of 'inherit' as display option, which is more user-friendly, it's enough to just delete the style when "<not set>" is selected. Also this option is missing from the Bulleted List type.
comment:14 Changed 14 years ago by
Also note that while adapting to the CSS style, we should still provide compatibility to the "type" attribute which make comes from content produced by v2.
comment:15 Changed 14 years ago by
Thanks for the patch. Suggestion: instead of <not set> or <Inherit> we could use <Default>
Changed 14 years ago by
Attachment: | 4358_3.patch added |
---|
comment:16 Changed 14 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:18 Changed 14 years ago by
Keywords: | Review- added; Review? removed |
---|
Finally, we need a mapping between attribute type and list-style-type.
Also, it's enough to use empty string for 'notset'.
Changed 14 years ago by
Attachment: | 4358_4.patch added |
---|
comment:19 Changed 14 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:20 Changed 14 years ago by
Keywords: | Review- added; Review? removed |
---|
That's great, but I think you misunderstood my points that the mapping should be applied to the 'setup' of list type instead of on 'commit':
this.setValue( element.getStyle( 'list-style-type' ) || mapListStyle[ element.getAttribute( 'type' ) ] || element.getAttribute( 'type' ) || '' );
comment:21 Changed 14 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:22 Changed 14 years ago by
Keywords: | Review- added; Review? removed |
---|
There's a problem with the current approach(also v2), with the following list, it's not able to recognize the list type properly.
<ul type="i"> <li>item</li> </ul>
Also, I can't get the 'start' field working.
Changed 14 years ago by
Attachment: | 4358_7.patch added |
---|
comment:23 Changed 14 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:24 Changed 14 years ago by
Keywords: | Review+ added; Review? removed |
---|
Be sure the following thing will happenen before committing:
- Register plugin into core config in alphabetic order;
- Run lang tool to update all other language files;
You can view the missing bullet properties @ http://ckeditor.com/demo
When do you think this could be fixed? Is there a workaround? I need the speed of CKeditor but without the list properties I have to stay with FCKeditor?