Opened 8 years ago

Closed 8 years ago

#4411 closed Bug (fixed)

Bad configuration options for SCAYT

Reported by: Alfonso Martínez de Lizarrondo Owned by:
Priority: Normal Milestone: CKEditor 3.3
Component: UI : Spell Checker Version: 3.0
Keywords: Confirmed Cc: spellchecker.net

Description

The initialization has this code

oParams.customDictionaryName = editor.config.scayt_customDictionaryName;
oParams.userDictionaryName = editor.config.scayt_userDictionaryName;
oParams.defLang = editor.scayt_defLang;

if ( CKEDITOR._scaytParams )
{
	for ( var k in CKEDITOR._scaytParams )
	{
		oParams[ k ] = CKEDITOR._scaytParams[ k ];
	}
}

Problems:

scayt_customDictionaryName and scayt_userDictionaryName aren't documented anywhere.

editor.scayt_defLang isn't using the config object so it's harder to change its value. Also, while trying to test it I wasn't able to make it work (or at least, make it work as I expected)

The CKEDITOR._scaytParams object means that any such option is shared by all the editor instances, instead of being able to configure each instance in a different way. It can't be overriden also in a configuration file. It's also hard to know what can be used there. Luckily I was able to find that sLang worked and help this user: http://cksource.com/forums/viewtopic.php?f=11&t=15705

Change History (4)

comment:1 Changed 8 years ago by WebSpellChecker.net

Resolution: fixed
Status: newclosed

patch is submitted in #5145

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: closedreopened

It's ok to indicate that this one is supposed to be fixed by another tickets, but it should be closed only after confirming the fix one the relative ticket gets closed.

comment:3 Changed 8 years ago by WebSpellChecker.net

Completely addressed in #5287.

comment:4 Changed 8 years ago by Garry Yao

Keywords: Confirmed added
Milestone: CKEditor 3.3
Resolution: fixed
Status: reopenedclosed

Fixed at #5287.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy