Opened 8 years ago

Closed 8 years ago

#4455 closed Bug (fixed)

Unable to start editing when image inside document not loaded

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Cc: diego@…

Description

If there's large image inside the editing document, the wysiwyg mode will be totally freezed while the image is loading.
Not sure if we could try to initialize the editing document a little bit earlier than 'onload', namely the 'onDomReady' technique.

Attachments (2)

4455.patch (2.0 KB) - added by Garry Yao 8 years ago.
4455_2.patch (1.1 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 8 years ago by Garry Yao

Ticket Test added at : http://ckeditor.t/tt/4455/1.html.

comment:2 Changed 8 years ago by Garry Yao

Milestone: CKEditor 3.1
Version: SVN (CKEditor)

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.1

Let's investigate it. It's an important issue.

Changed 8 years ago by Garry Yao

Attachment: 4455.patch added

comment:4 Changed 8 years ago by Garry Yao

Keywords: Confirmed Review? added
Owner: set to Garry Yao
Status: newassigned

The patch include the patch of dependent ticket #3598.

comment:5 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

I think you were talking about #3593 instead. The comments there make this patch not useful anymore.

Please do not mix the patches. You may indicated that a patch form other ticket must be also applied, or even point that we need to fix another ticket first.

Now, considering that the activationScript is appended to the document after the closing <html>, is the onload event really needed? Can't we call the "temporary function" directly?

Changed 8 years ago by Garry Yao

Attachment: 4455_2.patch added

comment:6 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

Ticket Manual Test added at :
http://ckeditor.t/tt/4455/1.html.

comment:7 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:8 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [4541].

comment:9 Changed 8 years ago by Diego Caravana

Cc: diego@… added
Resolution: fixed
Status: closedreopened

Sometimes the following code is appended to the content of the editor:

<script id="cke_actscrpt" type="text/javascript">window.​parent.​CKEDITOR._["con­tentDomReadyeditor"]( window );</script>

In my case, I save the content to the database to be used in a different context than a browser so the script tag creates a problem; in any case it should not be part of the real (user) content.

comment:10 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: reopenedclosed

Please don't reopen fixed ticket unless you're sure it's the regression that brought by the fixing, open new ticket instead.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy