Opened 13 years ago
Closed 13 years ago
#4504 closed Bug (fixed)
Enterkey is broken on dialog 'OK'/'Cancel' button
| Reported by: | Garry Yao | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Must have (possibly next milestone) | Milestone: | CKEditor 3.1 |
| Component: | UI : Enter Key | Version: | |
| Keywords: | Confirmed Review+ | Cc: |
Description
It's not able to trigger buttons' click behavior with 'enter key' in trunk.
Attachments (2)
Change History (8)
comment:1 Changed 13 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | new → assigned |
comment:2 Changed 13 years ago by
| Keywords: | Review? added |
|---|
Update the TC from the regression ticket: http://ckeditor.t/tt/4269/1.html.
Changed 13 years ago by
| Attachment: | 4504.patch added |
|---|
comment:3 Changed 13 years ago by
| Keywords: | Review- added; Review? removed |
|---|
Looks good... can we just have a more consistent naming? "stopBubble" is a mixture of "stopPropagation" and "cancelBubble" :)
Also, we're using a different convention for the attribute name and the method name here:
if ( stopPropagation )
this.stopBubble();
At this point, let's just call it "stopPropagation", which is also a well known name.
Changed 13 years ago by
| Attachment: | 4504_2.patch added |
|---|
comment:4 Changed 13 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:5 Changed 13 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
Note: See
TracTickets for help on using
tickets.
Regression of [4165] from #4269.
Where the default behavior( expected one ) was canceled.