Opened 8 years ago

Closed 8 years ago

#4504 closed Bug (fixed)

Enterkey is broken on dialog 'OK'/'Cancel' button

Reported by: Garry Yao Owned by: Garry Yao
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.1
Component: UI : Enter Key Version:
Keywords: Confirmed Review+ Cc:

Description

It's not able to trigger buttons' click behavior with 'enter key' in trunk.

Attachments (2)

4504.patch (1.1 KB) - added by Garry Yao 8 years ago.
4504_2.patch (1.7 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

Regression of [4165] from #4269.
Where the default behavior( expected one ) was canceled.

comment:2 Changed 8 years ago by Garry Yao

Keywords: Review? added

Update the TC from the regression ticket: http://ckeditor.t/tt/4269/1.html.

Changed 8 years ago by Garry Yao

Attachment: 4504.patch added

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

Looks good... can we just have a more consistent naming? "stopBubble" is a mixture of "stopPropagation" and "cancelBubble" :)

Also, we're using a different convention for the attribute name and the method name here:

if ( stopPropagation )
    this.stopBubble();

At this point, let's just call it "stopPropagation", which is also a well known name.

Changed 8 years ago by Garry Yao

Attachment: 4504_2.patch added

comment:4 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:5 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:6 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [4352].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy