Ticket #4511 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

'cssFloat'/'styleFloat' problem break dt/core/dom/element.html

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: SVN (CKEditor) - OLD
Keywords: IE Confirmed Cc:

Description

IE8 has fixed 'cssFloat' style property which preserving the 'styleFloat' for backward compatibility, which induce our feature detection logic:

var cssFloat = ( typeof test.cssFloat != 'undefined' ) ? 'cssFloat'
	: ( typeof test.styleFloat != 'undefined' ) ? 'styleFloat'
	: 'float';

Attachments

4511.patch (537 bytes) - added by garry.yao 5 years ago.

Change History

Changed 5 years ago by garry.yao

comment:1 Changed 5 years ago by garry.yao

  • Owner set to garry.yao
  • Keywords Review? added
  • Status changed from new to assigned

comment:2 Changed 5 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:3 Changed 5 years ago by fredck

  • Keywords IE Review- added; IE8 Review+ removed

That's really weird... but it looks like this fix must be applied to all IEs. We need investigation.

comment:4 Changed 5 years ago by fredck

As I was wondering the TC is wrong, not the core code. In the TC, we're always checking the "cssFloat" property of the style, and we need instead to check styleFloat in IE only.

comment:5 Changed 5 years ago by garry.yao

  • Status changed from assigned to closed
  • Keywords Review- removed
  • Resolution set to fixed

You're right, the TCs have instead been fixed with [4341].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy