Opened 8 years ago

Closed 8 years ago

#4512 closed Bug (fixed)

TC from dt/plugins/styles is broken because of semicolon fixing

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.1
Component: Core : Styles Version: SVN (CKEditor) - OLD
Keywords: Safari Confirmed Review+ Cc:

Description

Extra semicolons get introduced due to the following codes:

for ( var style in stylesDef )
 stylesText += style + ':' + stylesDef[ style ] + ';';

Attachments (2)

4512.patch (1.2 KB) - added by Garry Yao 8 years ago.
4512_2.patch (629 bytes) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by Garry Yao

Attachment: 4512.patch added

comment:1 Changed 8 years ago by Garry Yao

Keywords: Review? added
Owner: set to Garry Yao
Status: newassigned

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

I know it's a small repetition, but for this simple case, let's just try having the code simpler, amending just the following:

stylesText += ( style + ':' + stylesDef[ style ] ).replace( semicolonFixRegex, ';' );  

Changed 8 years ago by Garry Yao

Attachment: 4512_2.patch added

comment:3 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:5 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [4355].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy