Link selection - not always correct

[Andreas Greif]

Hello!

When I create a link in CKEditor 3.0 and want to edit it, there are several methods of selecting the link - i.e. double-click it or a simple click. They all work fine.

But if I click on the left side of a link, holding down the mouse-button, mark it to the right side of the link, release the button and then click "edit" - the URL field is always empty.

in almost all browsers - Firefox 2.0.0.20, 3.5 or IE 8 for example, I can see this behaviour.

Thanks!

[Garry Yao]

I click on the left side of a link, holding down the mouse-button, mark it to the right side of the link

It's not the correct way for select a link, and it's trivial.

[Frederico Caldeira Knabben]

This is definitely a bug.

[Garry Yao]

Screencast for reproduce: ​http://screencast.com/t/wROj4SXN

[Garry Yao]

More precise link detection from range.

[Frederico Caldeira Knabben]

• The range::trim change looks like a duplication of range::optimize. Am I wrong? Other than that, the documentation added is not understandable. And finally, the verb "trim" means really "cut out", so it's expected to have text nodes split.

• The changes at line 87 bring no benefit. They just make the code harder to read and longer.

[Garry Yao]

The changes at line 87 bring no benefit. They just make the code harder to read and longer.

That change was to guarantee the 'String' type of 'href' when the element is an anchor, so it's needed.

[Garry Yao]

Another R- reason for 4513.patch, where the link element is not detected in the following case:

[<b><a href="#">li]nk</a></b>]

[Garry Yao]

Replying to fredck:

• The range::trim change looks like a duplication of range::optimize. Am I wrong? Other than that, the documentation added is not understandable. And finally, the verb "trim" means really "cut out", so it's expected to have text nodes split.

You're definitely correct, we just need range::optimize here instead of changing range::trim.

[Garry Yao]

Providing a new patch that targeting the above issues and also take context-menu listener into consideration.

[Frederico Caldeira Knabben]

The getSelectedLink method should not make DOM changes.

[Garry Yao]

Introduce an unobtrusive way to implement 'getSelectedLink' in previous patch, by establishing a 'CKEDITOR.dom.range::shrink' method, of course TCs are available:
​run OR ​view source.

[Frederico Caldeira Knabben]

That's a very good fix. There are just some small notes:

• The "else" statement is not needed at line 1246 of range.js, because the "if" is using "return" on it.

• Please keep more attention to the spacing after the "if" statement, to avoid things like [5149], [5150] and [5152].

[Frederico Caldeira Knabben]

This patch must be re-proposed, considering that range::shrink has been introduced with [5255].

[Garry Yao]

Updated the patch with trunk.

[Garry Yao]

Fixed with [5304].