Opened 14 years ago
Closed 14 years ago
#4513 closed Bug (fixed)
Link selection - not always correct
Reported by: | Andreas Greif | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.3 |
Component: | General | Version: | 3.0 |
Keywords: | Confirmed Review+ | Cc: | pomu@… |
Description
Hello!
When I create a link in CKEditor 3.0 and want to edit it, there are several methods of selecting the link - i.e. double-click it or a simple click. They all work fine.
But if I click on the left side of a link, holding down the mouse-button, mark it to the right side of the link, release the button and then click "edit" - the URL field is always empty.
in almost all browsers - Firefox 2.0.0.20, 3.5 or IE 8 for example, I can see this behaviour.
Thanks!
Attachments (5)
Change History (26)
comment:1 Changed 14 years ago by
Keywords: | link select selection removed |
---|---|
Resolution: | → invalid |
Status: | new → closed |
comment:2 Changed 14 years ago by
Keywords: | Confirmed added |
---|---|
Milestone: | → CKEditor 3.2 |
Resolution: | invalid |
Status: | closed → reopened |
This is definitely a bug.
comment:4 Changed 14 years ago by
Cc: | pomu@… added |
---|
Changed 14 years ago by
Attachment: | 4513.patch added |
---|
comment:6 Changed 14 years ago by
Owner: | set to Garry Yao |
---|---|
Status: | reopened → new |
comment:7 Changed 14 years ago by
Status: | new → assigned |
---|
comment:8 follow-up: 11 Changed 14 years ago by
Keywords: | Review- added; Review? removed |
---|
- The range::trim change looks like a duplication of range::optimize. Am I wrong? Other than that, the documentation added is not understandable. And finally, the verb "trim" means really "cut out", so it's expected to have text nodes split.
- The changes at line 87 bring no benefit. They just make the code harder to read and longer.
comment:9 Changed 14 years ago by
The changes at line 87 bring no benefit. They just make the code harder to read and longer.
That change was to guarantee the 'String' type of 'href' when the element is an anchor, so it's needed.
comment:10 Changed 14 years ago by
Another R- reason for 4513.patch, where the link element is not detected in the following case:
[<b><a href="#">li]nk</a></b>]
Changed 14 years ago by
Attachment: | 4513_2.patch added |
---|
comment:11 Changed 14 years ago by
Replying to fredck:
- The range::trim change looks like a duplication of range::optimize. Am I wrong? Other than that, the documentation added is not understandable. And finally, the verb "trim" means really "cut out", so it's expected to have text nodes split.
You're definitely correct, we just need range::optimize here instead of changing range::trim.
comment:12 Changed 14 years ago by
Keywords: | Review? added; Review- removed |
---|
Providing a new patch that targeting the above issues and also take context-menu listener into consideration.
comment:13 Changed 14 years ago by
Keywords: | Review- added; Review? removed |
---|
The getSelectedLink method should not make DOM changes.
Changed 14 years ago by
Attachment: | 4513_3.patch added |
---|
comment:14 Changed 14 years ago by
Keywords: | Review? added; Review- removed |
---|
Introduce an unobtrusive way to implement 'getSelectedLink' in previous patch, by establishing a 'CKEDITOR.dom.range::shrink' method, of course TCs are available:
run OR view source.
comment:15 Changed 14 years ago by
Milestone: | CKEditor 3.2 → CKEditor 3.3 |
---|
comment:16 Changed 14 years ago by
Keywords: | Review- added; Review? removed |
---|
Changed 14 years ago by
Attachment: | 4513_4.patch added |
---|
comment:17 Changed 14 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:18 Changed 14 years ago by
Keywords: | Review- added; Review? removed |
---|
This patch must be re-proposed, considering that range::shrink has been introduced with [5255].
Changed 14 years ago by
Attachment: | 4513_5.patch added |
---|
comment:19 Changed 14 years ago by
Keywords: | Review? added; Review- removed |
---|
Updated the patch with trunk.
comment:20 Changed 14 years ago by
Keywords: | Review+ added; Review? removed |
---|
It's not the correct way for select a link, and it's trivial.