Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4547 closed New Feature (fixed)

Load the skin CSS in parallel

Reported by: Frederico Caldeira Knabben Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: 3.0
Keywords: Confirmed Cc:

Description

We're currently loading the skin CSS files only after the plugins files get loaded. This is not really necessary, and these files could be loaded in parallel, while the rest of the editor scripts get loaded.

Attachments (2)

4547.patch (916 bytes) - added by Garry Yao 8 years ago.
4547_firebug_netpanel_snapshots.png (39.4 KB) - added by Garry Yao 8 years ago.
Result Comparison

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by Frederico Caldeira Knabben

The solution for it could be quite simple. It's enough to (unblocked) load the skin files as the first thing right after loading the configuration file.

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Changed 8 years ago by Garry Yao

Attachment: 4547.patch added

Changed 8 years ago by Garry Yao

Result Comparison

comment:3 Changed 8 years ago by Garry Yao

Keywords: Review? added
Owner: set to Garry Yao
Status: newassigned

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The callback function at line 256 should not be removed. It'll not block for CSS files. It blocks only if the skin.js file needs to be downloaded.

Inside the above callback, we must call loadLang now, removing the call for it at line 130.

comment:5 Changed 8 years ago by Garry Yao

Depends on #4463.

comment:6 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed by #4463.

comment:7 Changed 8 years ago by Garry Yao

Keywords: Review- removed
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy