Float panel menu will not respond after the editor instance is re-created.

[markuspaek]

check '_samples/ajax.html' (this is from your current distribution)

1. Create an editor instance.
2. Click the toolbar buttons such as 'text color' or 'font size' and select something in the float panel menu.
3. Destroy the editor instance.
4. Create a new editor instance.
5. Then the toolbar buttons do not respond when clicked.

Firefox 3.5.3
Windows XP

[Matti Järvinen]

I noticed the same with IE8 and FF 3.5.3. With floatpanel buttons mentioned and format and style selections.

It seems to work the first time you use the button. On a second time with different instance floatpanel buttons that are unused work but after you have used them and destroy and create the instance again those buttons don't work anymore.

Is the floating selection created once (when shown) and instance of it saved in a variable that isn't cleared with editor.destroy() so it isn't recreated on a new instance?

Error I get is this.$ is undefined

Practically this is the showstoppper.

[Matti Järvinen]

related to #4241

panels get destroyed right but, panels[key] exists every time after the creation of the first editor with same parameters ( CKEDITOR.replace('editorField'); ) even though CKEDITOR.instances.editorField.destroy() is called.

plugins/floatpanel/plugin.js getPanel line 16-

var panel = panels[key];
...

return panel;

later on $ : function

...

// Register panels to editor for easy destroying ( #4241 ).
editor.panels ? editor.panels.push( element ) : editor.panels = [ element ];

themes/default/theme.js destroy line 156

var container = editor.container,
panels = editor.panels;

...
for( var i = 0 ; panels && i < panels.length ; i++ )
	panels[ i ].remove();

[Garry Yao]

@matti: Thanks for the wonderful bug reporting and issue catching which helps us to locate the bug in a second.

[Frederico Caldeira Knabben]

The proposed patch will not work if you have more than one instance of the editor in the page.

[Garry Yao]

After discuss with Fred, the patch break the panel sharing mechanism between editors, so another solution should be found.

[Garry Yao]

It's actually a regression of [4167] from [4241].

[Frederico Caldeira Knabben]

• Let's call the event "instanceDestroyed" instead of "instanceDestroy", just to be aligned with the "instanceCreated" name.

• editor.panels is not needed anymore. We can use only the private panels for all needs (hide and destroy them in the same loop).

• A "debugger" line remained in the code.

• The coding style is bad is several places. It deserves attention and correction.

[Garry Yao]

Corrected the above mentioned issue.