Opened 8 years ago

Closed 7 years ago

#4652 closed Bug (fixed)

Config for disable editor context menu

Reported by: Garry Yao Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.5
Component: UI : Context Menu Version:
Keywords: Cc:

Description

We should provide an option for disable context menu in editor, probably porting #311 from v2.

Attachments (3)

4652.patch (22.6 KB) - added by Garry Yao 7 years ago.
4652_2.patch (22.1 KB) - added by Tobiasz Cudnik 7 years ago.
4652_3.patch (22.1 KB) - added by Tobiasz Cudnik 7 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 Changed 8 years ago by Garry Yao

Actually here we just need to make it possible to disable it by simply remove the plugin itself, no new config introduced.

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.2CKEditor 3.3

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.3CKEditor 3.4

Changed 7 years ago by Garry Yao

Attachment: 4652.patch added

comment:4 Changed 7 years ago by Garry Yao

Keywords: Confirmed Review? added
Owner: set to Garry Yao
Status: newassigned

'contextmenu' plugin is no longer required by 'menubutton' thus can be removed from plugin list to reveal the native context menu.

comment:5 Changed 7 years ago by Alfonso Martínez de Lizarrondo

It seems to me that the overall idea and changes are OK, but due to the number of changes, I would like that someone else could look also at the patch.

comment:6 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review- added; Review? removed

There's some error with this patch:

in IE8, select some word and open the context menu, dismiss it, select something else and trying to open the context menu will throw an error. If the second time nothing is selected, the context menu opens, and when it's closed it selects back the first range.

comment:7 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4CKEditor 3.5

comment:8 Changed 7 years ago by Tobiasz Cudnik

Owner: changed from Garry Yao to Tobiasz Cudnik
Status: review_failedassigned

I'm taking this one over Garry.

Changed 7 years ago by Tobiasz Cudnik

Attachment: 4652_2.patch added

comment:9 Changed 7 years ago by Tobiasz Cudnik

Status: assignedreview

Reason for non unlocked selection on IE was unexecuted onHide listener.

comment:10 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4.1CKEditor 3.5

comment:11 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

There's an error thrown when menu is hide at L145 of menu/plugin.js.

Changed 7 years ago by Tobiasz Cudnik

Attachment: 4652_3.patch added

comment:12 Changed 7 years ago by Tobiasz Cudnik

Status: review_failedreview

comment:13 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

Nice done!

comment:14 Changed 7 years ago by Tobiasz Cudnik

Keywords: Confirmed removed
Resolution: fixed
Status: review_passedclosed

Fixed with [5937].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy