Opened 8 years ago

Closed 8 years ago

#4725 closed Bug (fixed)

hitting return after html comment produces an error "t.getName is not a function"

Reported by: tyler45 Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.1
Component: UI : Enter Key Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Cc:

Description

hi,

when a paragraph ends in an html comment, hitting the enter key with the cursor positioned at the end of this paragraph (to create a new paragraph) throws an error "t.getName is not a function" (line 29 ckeditor.js).

<p>Any old para.<!-- any old comment --></p>

Windows Vista SP2 FF 3.5.5

Attachments (2)

4725.patch (461 bytes) - added by Garry Yao 8 years ago.
4725_2.patch (488 bytes) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by Garry Yao

Attachment: 4725.patch added

comment:1 Changed 8 years ago by Garry Yao

Component: GeneralUI : Enter Key
Keywords: Confirmed Review? added
Milestone: CKEditor 3.1
Owner: set to Garry Yao
Status: newassigned
Version: SVN (CKEditor)

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

Please use the type property to check the node type. I know it'll add 5 bytes more to the code, but we have already understood that using methods to check for node types is a bad practice.

Changed 8 years ago by Garry Yao

Attachment: 4725_2.patch added

comment:3 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:5 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [4596].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy