Opened 10 years ago

Last modified 9 years ago

#4785 review_failed Bug

Incorrect tab key order for table properties dialog

Reported by: Garry Yao Owned by: brooks
Priority: Normal Milestone:
Component: UI : Dialogs Version: SVN (CKEditor) - OLD
Keywords: Cc:

Description

Reproducing Procedures

  1. Open 'replacebyclass' sample page insert an default table.
  2. Click inside one of the table cell and open context menu on it.
  3. Click 'Table Properties' to open the dialog.
  4. Press 'Tab' key to iterate over all dialog fields.
  • Actual Result: Some fields will be skipped before reach the dialog buttons.

Attachments (2)

4785.patch (493 bytes) - added by brooks 9 years ago.
4785_2.patch (887 bytes) - added by brooks 9 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.1CKEditor 3.2

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.2CKEditor 3.3

comment:3 Changed 9 years ago by Garry Yao

Milestone: CKEditor 3.3CKEditor 3.4

Changed 9 years ago by brooks

Attachment: 4785.patch added

comment:4 Changed 9 years ago by brooks

Owner: set to brooks
Status: newassigned

comment:5 Changed 9 years ago by brooks

Keywords: Review? added; Confirmed removed
  1. the simplest way to fix this problem is not make a default focus, cos it disarranged the focus sequence. this is my chosen
  1. an optional way may be rearrange the dialog's elements layout sequence, e.g. switch the 'selHeaders' select with 'txtWidth' input( and other element switch);
  1. adjust the focusList by hand, I think this is not scalable .

Changed 9 years ago by brooks

Attachment: 4785_2.patch added

comment:6 Changed 9 years ago by brooks

pls neglect the first patch

comment:7 Changed 9 years ago by Garry Yao

Keywords: Review- added; Review? removed

I'm not sure this will be a good deal, as the smart focus is a friendly feature also exists in other places, e.g. Link dialog, where we have the same problem, we may even consider a wontfix for this one if no decent solution could be found.

comment:8 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy