Opened 9 years ago

Closed 9 years ago

#4786 closed Bug (fixed)

Changing paragraph format doesn't work in some situations

Reported by: Wiktor Walc Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ 3.0.2 Cc:

Description (last modified by Wiktor Walc)

This is a regression bug, works in CKEditor 3.0.1.

Steps to reproduce:

  • open replacebyclass sample
  • select the whole first line
  • change format to "Formatted"
  • expected result: text is surrounded with <pre> tag
  • actual result: no changes (<p> tag is still there)

Attachments (1)

4786.patch (881 bytes) - added by Frederico Caldeira Knabben 9 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: WorksForMe added

WFM with both FF3.5 and IE8. Is there any further details on this?

comment:2 Changed 9 years ago by Wiktor Walc

I am selecting the text (the whole line) with a mouse in FF 3.5.5, if I select the p tag at the bottom of the editor it works fine. It does not work also if you place the cursor at the beginning and press Shift + End to select the paragraph and then change the format.

comment:3 Changed 9 years ago by Wiktor Walc

Description: modified (diff)
Summary: <pre> support is brokenChanging paragraph format doesn't work in some situations

Hmm actually it has nothing to do with the <pre> tag... the format is simply not changing and it doesn't matter whether it is a heading or something else (I have modified the ticket).

comment:4 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added; WorksForMe removed

Ok... true... confirmed with IE8 when using CTRL+A to select all.

comment:5 Changed 9 years ago by Wiktor Walc

Apart form problems with changing format when (for example) Ctrl+A is used to select everything, there is also a problem with the blockquote button:

  • open IE8
  • having the following text:
    <p>
    	This is some <strong>sample text</strong>. You are using <a href="http://ckeditor.com/">CKEditor</a>.</p>
    
    press Ctrl + A to select everything
  • click the blockquote button
  • result (in IE8):
    <p>
    	&nbsp;</p>
    <blockquote>
    	<p>
    		</p>
    </blockquote>
    <p>
    	This is some <strong>sample text</strong>. You are using <a href="http://ckeditor.com/">CKEditor</a>.</p>
    

this bug can be also reproduced in FF 3.5.5 when moving cursor at the beginning of line and using Shift+End to select the text instead of pressing Ctrl + A.

I think this is the same bug, just wanted to add another example of reproducing it.

comment:6 Changed 9 years ago by Frederico Caldeira Knabben

Regression introduced with [4691].

Changed 9 years ago by Frederico Caldeira Knabben

Attachment: 4786.patch added

comment:7 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review? added

The proposed patch reverts some of the changes introduced with [4691] without impacting on #4450.

comment:8 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: 3.0.2 added

comment:9 Changed 9 years ago by Frederico Caldeira Knabben

Owner: set to Frederico Caldeira Knabben
Status: newassigned

comment:10 Changed 9 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:12 Changed 9 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Fixed with [4720].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy