Opened 11 years ago

Closed 10 years ago

#479 closed Bug (fixed)

o:p tags cause linebreak problems in IE6/7

Reported by: Michael Ney Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.6
Component: UI : Enter Key Version:
Keywords: Confirmed IE Review+ Cc:

Description

Occurs in IE6 and IE7. Does not occur in Firefox.


How to reproduce:

In source mode, add the content: <o:p>Some Content</o:p>

Exit source mode. Press Enter.

You will find that no linebreak occurs. When you return to the source view, you will see a </o:p><o:p> was added. This occurs even if the <o:p></o:p> is between <p></p> tags.

And further, MS Word sometimes leaves a trailing <o:p></o:p> at the end of lines when importing. This results in people asking, "Why is my enter key not making a line break?"

Attachments (2)

479.patch (1.2 KB) - added by Martin Kou 10 years ago.
479_2.patch (1.2 KB) - added by Martin Kou 10 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Confirmed IE added; o:p removed
Milestone: FCKeditor 2.6

Confirmed with IE6. Ok with FF2.

With the SVN trunk, an error is thrown instead.

Of course, we recommend users to use "Paste from Word" to remove such kind of Word tags on pasting.

comment:2 Changed 10 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

Changed 10 years ago by Martin Kou

Attachment: 479.patch added

comment:3 Changed 10 years ago by Martin Kou

Keywords: Review? added

comment:4 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

Even if scopeName is an IE only beast, it doesn't tell us that the scope in not present in the name. We should instead specifically restrict the check to IE, as it may happen that other browsers (typically Opera) may implement this property anytime in the future, potentially breaking our code:

if ( FCKBrowserInfo.IsIE && e.scopeName != 'HTML' ) 

comment:5 Changed 10 years ago by Martin Kou

Keywords: Review? added; Review- removed

Updated patch to add browser check.

Changed 10 years ago by Martin Kou

Attachment: 479_2.patch added

comment:6 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:7 Changed 10 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with [1569].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy