Opened 8 years ago

Closed 7 years ago

#4790 closed Bug (fixed)

CKEditor in enterMode = BR, problem with bullet list

Reported by: Wiktor Walc Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.4.3
Component: Core : Lists Version: 3.0
Keywords: Opera Cc:

Description

This ticket is similar to #3836. I think it happens only in Opera (tested on 10.10).

  1. Open the replace by code example page with enterMode = BR;
  2. Make the content and selection as below:
    line1
    <ul><li>[item1</li><li>item2]</li></ul>
    line2
    
  3. Click on 'Bullet List' to remove list;
  • Expected Result:
    line1<br />
    item1<br />
    item2<br />
    line2
    
  • Actual Result:
    line1<br />
    item1item2<br />
    line2
    

Attachments (1)

4790.patch (1.6 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 8 years ago by Wiktor Walc

Component: GeneralCore : Lists

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x

Milestone CKEditor 3.x deleted

comment:4 Changed 7 years ago by Krzysztof Studnik

Summary: [Opera]CKEditor in enterMode = BR, problem with bullet list

Changed 7 years ago by Garry Yao

Attachment: 4790.patch added

comment:5 Changed 7 years ago by Garry Yao

Milestone: CKEditor 3.5
Owner: set to Garry Yao
Status: confirmedreview

comment:6 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.5CKeditor 3.4.3

comment:7 Changed 7 years ago by Tobiasz Cudnik

It works well for me in Opera and others, although i'm thinking why not to change the appendBogus method which appends an empty text node for Opera only.

comment:8 in reply to:  7 Changed 7 years ago by Frederico Caldeira Knabben

Replying to tobiasz.cudnik:

It works well for me in Opera and others, although i'm thinking why not to change the appendBogus method which appends an empty text node for Opera only.

Do you mean having the entire fix there?

comment:9 Changed 7 years ago by Garry Yao

I'm ok with fixing only appendBogus, while Fred had told me before for "some reason" that we kept using empty space as bogus for Opera.

comment:10 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_passed

I'm not getting same results after patching just appendBogus, for first linebreak you have to hit Enter twice.

So R+ for the 4790 patch.

comment:11 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6112].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy