Opened 8 years ago

Closed 8 years ago

#4874 closed Bug (fixed)

IE: Context menu is not working for object selections

Reported by: Frederico Caldeira Knabben Owned by: Garry Yao
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.1
Component: UI : Context Menu Version: SVN (CKEditor) - OLD
Keywords: Confirmed IE Review+ Cc: pomu@…

Description

When opening the context menu for object selections, like image, flash or anchor, and then select the relative properties dialog, the dialog doesn't get filled. By closing the dialog is also possible to see that the object lost its selection.

Attachments (2)

4874.patch (1.4 KB) - added by Garry Yao 8 years ago.
4874_2.patch (2.6 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by pomu0325

This happens since [4482] in pasting branch.

comment:2 Changed 8 years ago by pomu0325

Cc: pomu@… added

I don't see any relevance, but It worked fine when I revert the change for 'beforepaste' to 'paste'.

comment:3 Changed 8 years ago by pomu0325

In r4482, I also observed that " " is appended to the end of text when context menu is shown by right click. It seems to me that codes for deciding whether to enable or disable 'Paste' context menu somehow calls actual paste, and it moves the selection, so this problem happens.

Hope this might help.

Changed 8 years ago by Garry Yao

Attachment: 4874.patch added

comment:4 Changed 8 years ago by Garry Yao

Component: GeneralUI : Context Menu
Keywords: Review? added
Owner: set to Garry Yao
Status: newassigned

@pomu You have an eagle eye.

comment:5 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The patch fixed the issue, partially. The remaining problem is that now you must first click on the object with the left mouse button (select it) and then right-click for the context menu. With the 3.0.2, you can right-click objects directly, without selecting them first (right-click selects them).

Changed 8 years ago by Garry Yao

Attachment: 4874_2.patch added

comment:6 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

The patch fixed the issue, partially.

Thanks for this careful catch, other part of this bug is regression from [4609] on 3.1.x branch.

comment:7 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:8 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [4797].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy