Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#5070 closed Bug (expired)

jQuery adapter and jQuery 1.4 compatibility

Reported by: Tobiasz Cudnik Owned by: Tobiasz Cudnik
Priority: Normal Milestone:
Component: General Version: 3.1
Keywords: Pending Cc: aske@…

Description (last modified by Tobiasz Cudnik)

As reported in blog post comment, there is an unknown issue with jQuery adapter and jQuery 1.4 when included from same server.

Although adapter seems to work well with jQuery 1.4.1 included directly from googleapis.

Change History (6)

comment:1 Changed 8 years ago by Tobiasz Cudnik

Description: modified (diff)
Owner: set to Tobiasz Cudnik
Status: newassigned

comment:2 Changed 8 years ago by Aske Hansen

Cc: aske@… added

comment:3 Changed 8 years ago by Tony

Instead of :

	var jQuery = window.jQuery;

Maybe try :

var jQuery = window.jQuery.noConflict();

http://docs.jquery.com/Using_jQuery_with_Other_Libraries

Also, anonymous calls to jQuery now return nothing in 1.4 :

jQuery().ajaxStop(function(){
    
    // some code

    });

Whereas that kind of thing used to work, you must now use document exclusively like this :

jQuery(document).ajaxStop(function(){
    
    // some code

    });

The only exception is :

    jQuery(function() { 

    // some code

    });

Which will always work.

There is the jQuery compatibility library to point people with jQuery 1.4 to and that might make the connector work until you fix the connector to work with 1.4.x.

One last gotcha is that the jQuery team have switched to closure, so you might want to investigate CKEditor doing the same to increase compatibility and reduce the risk of bugs. (Just don't use closure's advanced mode. It's a nightmare.)

comment:4 Changed 7 years ago by Tobiasz Cudnik

Keywords: Pending added
Milestone: CKEditor 3.3CKEditor 3.x

After some tests with various sources of jQuery 1.4.2 (local, code.jquery.com, minified, source) all of them worked fine.

If someone is able to reproduce this issue please post steps required to do that.

comment:5 Changed 7 years ago by Tobiasz Cudnik

Resolution: expired
Status: assignedclosed

Expired, please reopen if anybody can confirm this.

comment:6 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy