Ticket #5070 (closed Bug: expired)

Opened 4 years ago

Last modified 4 years ago

jQuery adapter and jQuery 1.4 compatibility

Reported by: tobiasz.cudnik Owned by: tobiasz.cudnik
Priority: Normal Milestone:
Component: General Version: 3.1
Keywords: Pending Cc: aske@…

Description (last modified by tobiasz.cudnik) (diff)

As reported in blog post comment, there is an unknown issue with jQuery adapter and jQuery 1.4 when included from same server.

Although adapter seems to work well with jQuery 1.4.1 included directly from googleapis.

Change History

comment:1 Changed 4 years ago by tobiasz.cudnik

  • Owner set to tobiasz.cudnik
  • Status changed from new to assigned
  • Description modified (diff)

comment:2 Changed 4 years ago by Aske

  • Cc aske@… added

comment:3 Changed 4 years ago by tony

Instead of :

	var jQuery = window.jQuery;

Maybe try :

var jQuery = window.jQuery.noConflict();

http://docs.jquery.com/Using_jQuery_with_Other_Libraries

Also, anonymous calls to jQuery now return nothing in 1.4 :

jQuery().ajaxStop(function(){
    
    // some code

    });

Whereas that kind of thing used to work, you must now use document exclusively like this :

jQuery(document).ajaxStop(function(){
    
    // some code

    });

The only exception is :

    jQuery(function() { 

    // some code

    });

Which will always work.

There is the jQuery compatibility library to point people with jQuery 1.4 to and that might make the connector work until you fix the connector to work with 1.4.x.

One last gotcha is that the jQuery team have switched to closure, so you might want to investigate CKEditor doing the same to increase compatibility and reduce the risk of bugs. (Just don't use closure's advanced mode. It's a nightmare.)

comment:4 Changed 4 years ago by tobiasz.cudnik

  • Keywords Pending added
  • Milestone changed from CKEditor 3.3 to CKEditor 3.x

After some tests with various sources of jQuery 1.4.2 (local, code.jquery.com, minified, source) all of them worked fine.

If someone is able to reproduce this issue please post steps required to do that.

comment:5 Changed 4 years ago by tobiasz.cudnik

  • Status changed from assigned to closed
  • Resolution set to expired

Expired, please reopen if anybody can confirm this.

comment:6 Changed 4 years ago by fredck

  • Milestone CKEditor 3.x deleted
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy