Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#5074 closed Bug (fixed)

Link target is not removed when changing to popup

Reported by: Frederico Caldeira Knabben Owned by: Martin
Priority: Normal Milestone: CKEditor 3.4.2
Component: General Version: SVN (CKEditor) - OLD
Keywords: Cc:

Description

  1. Load this HTML:
    <p><a href="http://example.com" target="_self">Link</a></p>
    
  1. Open the link dialog for that think.
  2. In the "Target" tab, select the "<popup window>" option and give it a name like "MyPopup".
  3. Confirm the dialog and look at the source.

The previous "target" attribute will still be there. I should have been removed instead.

Attachments (2)

5074.patch (579 bytes) - added by Martin 7 years ago.
Patch
5074_2.patch (512 bytes) - added by Martin 7 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x

Milestone CKEditor 3.x deleted

comment:2 Changed 7 years ago by Martin

Owner: set to Martin
Status: confirmedassigned

Changed 7 years ago by Martin

Attachment: 5074.patch added

Patch

comment:3 Changed 7 years ago by Martin

Status: assignedreview

comment:4 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_failed

The patch is OK, although coding style is wrong and there also unneeded change on L1254.

comment:5 Changed 7 years ago by Frederico Caldeira Knabben

Additionally, the comments can be a bit more verbose and meaningful, like:

// Remove the "target" attribute. (#5074)

I know it's a bit too obvious, but gives a bit of sense to the ticket number.

Changed 7 years ago by Martin

Attachment: 5074_2.patch added

comment:6 Changed 7 years ago by Martin

Status: review_failedreview

Line 1254 is need bacuese without them in IE dialog working wrong.

comment:7 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_passed

comment:8 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4.2

comment:9 Changed 7 years ago by Martin

Resolution: fixed
Status: review_passedclosed

fixed with revision [5929]

comment:10 Changed 7 years ago by Martin

fixed with revision [5923]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy