Opened 8 years ago

Closed 7 years ago

#5121 closed Bug (fixed)

Selecting line and changing Paragraph Format changes all lines in paragraph

Reported by: rgm Owned by: brooks
Priority: Normal Milestone: CKEditor 3.3
Component: Core : Styles Version: SVN (CKEditor) - OLD
Keywords: Review+ Cc: technology@…

Description

The FCK editor allows you to only change the selected line with Paragraph Format, i.e. it recognizes the <br /> tag as a separator. This doesn't work in the CKEditor.

Firefox on Mac

  • Type some text separated with a <br /> tag.
  • Select a line and change the Paragraph Format.
  • All lines change (not just the selected line).

Attachments (5)

5121.patch (448 bytes) - added by brooks 7 years ago.
5121_2.patch (1.3 KB) - added by brooks 7 years ago.
5121_3.patch (1.1 KB) - added by brooks 7 years ago.
5121_4.patch (1009 bytes) - added by brooks 7 years ago.
5121_5.patch (1.4 KB) - added by brooks 7 years ago.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 8 years ago by Garry Yao

Component: GeneralCore : Styles
Keywords: Confirmed added
Milestone: CKEditor 3.3
Version: 3.1SVN (CKEditor)

Similar with #4046.

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

This one is supposed to be fixed only when enterMode=BR.

comment:3 Changed 7 years ago by brooks

Owner: set to brooks
Status: newassigned

Changed 7 years ago by brooks

Attachment: 5121.patch added

comment:4 Changed 7 years ago by brooks

Keywords: Review? added; Confirmed removed

comment:5 Changed 7 years ago by Garry Yao

Keywords: Review- added; Review? removed

CKEDITOR.config != editor.config

Changed 7 years ago by brooks

Attachment: 5121_2.patch added

comment:6 Changed 7 years ago by brooks

Keywords: Review? added; Review- removed

comment:7 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The patch makes the CKEDITOR.style class dependent on the editor object, unnecessarily. It also makes the setEditor call mandatory when applying a block style, otherwise the applyBlockStyle function breaks.

What we could have instead is an *optional* property named "enterMode" in CKEDITOR.style class instances which defaults to CKEDITOR.ENTER_P if not defined.

Changed 7 years ago by brooks

Attachment: 5121_3.patch added

comment:8 Changed 7 years ago by brooks

Keywords: Review? added; Review- removed

nice idea~much safe now

Changed 7 years ago by brooks

Attachment: 5121_4.patch added

comment:9 Changed 7 years ago by brooks

please review both 5121_3.path and 5121_4.patch

IMO,5124_4.patch is better:-)

comment:10 Changed 7 years ago by Garry Yao

Keywords: Review- added; Review? removed

5124_4.patch is the right way for it, besides, 'format' plugin should be included into the fix.

Changed 7 years ago by brooks

Attachment: 5121_5.patch added

comment:11 Changed 7 years ago by brooks

Keywords: Review? added; Review- removed

comment:12 Changed 7 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:13 Changed 7 years ago by brooks

Resolution: fixed
Status: assignedclosed

fixed with 5402 5402

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy