Opened 7 years ago

Closed 7 years ago

#5127 closed Bug (fixed)

Problem with removing advanced tab in link and image dialogs

Reported by: Damian Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.2
Component: UI : Dialogs Version: SVN (CKEditor) - OLD
Keywords: IBM Confirmed Review+ Cc:

Description

Insert the following code after CKEDITOR.replace( 'editor1' ); in ckeditor/_samples/replacebycode.html

CKEDITOR.on('dialogDefinition', function( ev )
{

	var dialogName = ev.data.name;  
	var dialogDefinition = ev.data.definition;
   
	switch (dialogName) {  
	case 'image': //Image Properties dialog      
		dialogDefinition.removeContents('advanced');
		break;      
	case 'link': //image Properties dialog          
		dialogDefinition.removeContents('advanced');   
		break;
	}
});

This should remove the advanced tab from the image and link dialogs.
Save the html page and view it in a web browser.
Click on the 'Insert Link' toolbar icon.
The advanced tab is removed.
Click cancel - the dialog closes correctly.
Open the dialog again.
Enter a link and click ok.
The dialog closes and the link is inserted correctly into the editor.
Now click on the 'Insert Image' toolbar icon.
The advanced tab is removed.
Click cancel - the dialog does not close and an error is shown in the console.
Entering an image url and clicking ok does not close the dialog either.
The only way to recover is to close the browser tab / window.

Error in Firebug:

this._.contents[pageId] is undefined
[Break on this error] return this._.contents[pageId][elementId];\r\n

Attachments (1)

5127.patch (468 bytes) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by Garry Yao

Attachment: 5127.patch added

comment:1 Changed 7 years ago by Garry Yao

Component: GeneralUI : Dialogs
Keywords: Confirmed Review? added
Owner: set to Garry Yao
Status: newassigned
Version: SVN (CKEditor)

comment:2 Changed 7 years ago by Garry Yao

Priority: HighNormal

comment:3 Changed 7 years ago by Garry Yao

#5126 has been marked as duplicate.

comment:4 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review+ added; Review? removed

I'm not sure if there is even another ticket filed with related problems, anyway, we will find it later in future reviews of pending tickets.

comment:5 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [5105].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy