Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#5170 closed Bug (fixed)

Problems with pasting (executing insertHtml) and formatted text

Reported by: Wiktor Walc Owned by: brooks
Priority: Normal Milestone: CKEditor 3.3
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Cc:

Description

When inserting content with insertHtml() inside of formatted text, editor breaks formatting and inserts content without formatting. Confirmed in FF 3.5. Works fine in IE8 and Safari 4.

Steps to reproduce

  • start with
    <p>
    	<span style="color: rgb(255, 0, 0);">Sample ^text</span></p>
    
  • Open "special character" dialog and insert some character somewhere in the middle of the text (before "text")
  • Result:
    <p>
    	<span style="color: rgb(255, 0, 0);">Sample </span>&euro;<span style="color: rgb(255, 0, 0);">text</span></p>
    

This can be reproduced in many different ways in CKEditor, everywhere where insertHtml() is used, like also when pasting content or when inserting content in a custom plugin.

Targetting to 3.3 as it might be a bit irritating.

Attachments (2)

5170.patch (2.9 KB) - added by brooks 8 years ago.
5170_2.patch (1.3 KB) - added by brooks 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by brooks

Version: SVN (CKEditor)

comment:2 Changed 8 years ago by brooks

Owner: set to brooks
Status: newassigned

comfirmed in Firefox3

this is firefox's own bug,it was done by

'trunk/_source/plugins/wysiwygarea/plugin.js' #48 line

this.document.$.execCommand( 'inserthtml', false, data );

so,after a talk with Garry,we decided to use another way to insert special chars

Changed 8 years ago by brooks

Attachment: 5170.patch added

Changed 8 years ago by brooks

Attachment: 5170_2.patch added

comment:3 Changed 8 years ago by brooks

Keywords: Review? added; Confirmed Firefox removed

comment:4 Changed 8 years ago by Garry Yao

Keywords: Review+ added; Review? removed

Cong to Brooks' first commit!

comment:5 Changed 8 years ago by brooks

Keywords: Review+ removed
Resolution: fixed
Status: assignedclosed

comment:6 Changed 8 years ago by brooks

Keywords: Confirmed Review+ added

comment:7 Changed 8 years ago by brooks

fixed with http://dev.fckeditor.net/changeset/5273 ,where,this is still a temporary fix

comment:8 Changed 8 years ago by Wiktor Walc

This issue exists everywhere where insertHtml is used, so it shouldn't be fixed in the specialchar dialog, see #5536.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy