Opened 15 years ago
Closed 14 years ago
#5335 closed Bug (fixed)
Several lines' formatted data will be merged to one line when we apply Numbers/Bullets
Reported by: | Satya Minnekanti | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.4.1 |
Component: | UI : Toolbar | Version: | 3.2 |
Keywords: | IBM | Cc: | Damian, joek |
Description
To reproduce the defect
- Open ajax sample and type some 4 lines of text( eg: test 1 test 2 test 3 each on a diff line)
- Select all the lines and apply Formatting paragraph format option to them.
- Now click on Numbers/Bullets Icon
Expected Result:we should see that Numbers/Bullets is applied to the lines
Actual Result: All the four lines of data are merged in to a single line.
Attachments (3)
Change History (13)
comment:1 Changed 15 years ago by
Keywords: | Pending added |
---|
comment:3 Changed 15 years ago by
Keywords: | Confirmed added; Pending removed |
---|---|
Milestone: | CKEditor 3.3 → CKEditor 3.x |
Converting pre-formatted content to list should behave just like apply bock style - with line break preserved, but it's not of high priority, since at least we have the right result by first apply "Paragraph" on it before convert to list.
comment:4 Changed 15 years ago by
Milestone: | CKEditor 3.x → CKEditor 3.3 |
---|
Yes it should behave like block style, but doesn't at the moment.
I don't understand the justification for treating it as low priority, considering that it doesn't work as the feature is meant to work.
Changed 15 years ago by
Attachment: | 5335.patch added |
---|
comment:5 Changed 15 years ago by
Keywords: | Review? added |
---|---|
Owner: | set to Garry Yao |
Status: | new → assigned |
comment:6 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|---|
Milestone: | CKEditor 3.3 → CKEditor 3.4 |
The <pre> block is a special case in the editor as it deals with raw text, unlike other blocks, where line breaks are treated differently. It behaves differently in the editor. For example, if you switch from <pre> to <p> with a collapsed selection, the entire <pre> is converted, not only the line with the caret.
We should have the same behavior here, having the entire <pre> being moved inside an <li>, just like we're doing now with the headings tags. So, in the ticket tc, we would end up with a single <ul><li><pre>...</pre></li></ul> result.
I would understand a different behavior only if it would be possible to have lists inside <pre>, which is not true,
Changed 15 years ago by
Attachment: | 5335_2.patch added |
---|
comment:7 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|
...the entire <pre> is converted, not only the line with the caret.
Ok, it's a reasonable proposal as it matches the browser's native create list command also.
comment:8 Changed 14 years ago by
Milestone: | CKEditor 3.4 → CKEditor 3.5 |
---|
comment:9 Changed 14 years ago by
Keywords: | Confirmed removed |
---|---|
Status: | review → review_passed |
comment:10 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [5875].
Do you mean 'Formatted' (pre) format option?