Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#5415 closed Bug (fixed)

Undo not working when we change the Table Properties for the table on a saved page

Reported by: Satya Minnekanti Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.4
Component: Core : Undo & Redo Version: 3.0
Keywords: IBM Confirmed Review+ Cc: joek, Damian

Description

To reproduce the defect

  1. Open Ajax sample.
  1. Insert a Table and enter the text in Table Cells.
  1. Click on Remove Editor button to save the Page.
  1. Click on Create Editor button to open the page again.
  1. Go in to one of Table cells and Open Table Context menu and Click on Table Properties.
  1. In Table Properties dialog change Table Alignment to Center and Click OK.

Expected Result

Table is Aligned to Center and the Undo button should be enabled.

Actual Result

Table is Aligned to the Center but the Undo button is not enabled and it will not enable even if we change any number of Table Properties.It is only enabled when we type some text in the Editor.

Attachments (1)

5415.patch (1.2 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.3CKEditor 3.4

Changed 8 years ago by Garry Yao

Attachment: 5415.patch added

comment:2 Changed 8 years ago by Garry Yao

Component: GeneralCore : Undo/Redo
Keywords: Confirmed Review? added
Owner: set to Garry Yao
Status: newassigned
Version: 3.23.0

We have similar issues in other dialogs, e.g. insert Link, it's not bad to take a bit automation here.

comment:3 Changed 7 years ago by Tobiasz Cudnik

Keywords: Review+ added; Review? removed

This is a good solution which resolves other issues like #5846.

We may additionally remove some savesnapshot events in other dialogs, which will be unnecessary after this fix.

comment:4 Changed 7 years ago by Tobiasz Cudnik

Resolution: fixed
Status: assignedclosed

Fixed with [5669].

comment:5 Changed 7 years ago by Tobiasz Cudnik

Committed into correct branch with [5693].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy