Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#5546 closed Bug (fixed)

SCAYT breaks undo system

Reported by: Garry Yao Owned by:
Priority: Normal Milestone: CKEditor 3.3
Component: UI : Spell Checker Version: 3.0
Keywords: Confirmed Cc:


Reproducing Procedures

  1. Open 'replacebyclass' sample page;
  2. Enable 'SCAYT' and wait for SCAYT to be activiated;
  3. Put cursor inside the word 'sample' as following:
  4. Open 'Smiley' dialog to insert one default icon at the cursor position;
  5. Wait until the SCAYT has finished marking the mis-spelled word 'sam' and 'ple' respectively;
  6. Press 'Undo' button to revert the smiley insertion;
    • Actual Result: The SCAYT mark line was reverted but not the smiley icon.
    • Expected Result: Both smiley icon insertion and SCAYT mark get reverted.

Attachments (2)

5546.patch (2.5 KB) - added by 14 years ago.
5546_2.patch (4.1 KB) - added by 14 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 14 years ago by Garry Yao

Note that there're two problems involved here:

  1. First of all, SCAYT should refresh after undo;
  2. Second, SCAYT has to notify our undo system of the newly added SCAYT word markers.

Changed 14 years ago by

Attachment: 5546.patch added

Changed 14 years ago by

Attachment: 5546_2.patch added

comment:2 Changed 14 years ago by

SCAYT instance status check was added ( was led to error whet text source edit )

comment:3 Changed 14 years ago by Garry Yao

Resolution: fixed
Status: newclosed

Fixed with [5485] with dead code blocks removed.

comment:4 Changed 14 years ago by Alfonso Martínez de Lizarrondo

This has broken the undo system if there is no instance named "editor1" #5685

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy