Opened 8 years ago

Closed 8 years ago

#5553 closed Bug (fixed)

Cursor location in Paste from Word and Paste dialogs is incorrect for BIDI languages

Reported by: Satya Minnekanti Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.3
Component: UI : Language Version: 3.0
Keywords: IBM Confirmed Review+ Cc: Damian, joek

Description

To reproduce the defect:

  1. Open http://nightly.ckeditor.com/5388/_samples/ui_languages.html
  1. Select Arabic or Hebrew in the languages drop don list
  1. Click on Paste from Word or Paste Icons in the Toolbar

Expected Result: Paste from Word or Paste dialog is opened and the Cursor is on the right-side of the text area

Actual Result: Paste from Word or Paste dialog is opened and the Cursor is on the left-side of the text area.

The Cursor Position is shown properly in Paste as Plain Text dialog.

Attachments (4)

5553.patch (902 bytes) - added by Garry Yao 8 years ago.
5553_2.patch (1.2 KB) - added by Garry Yao 8 years ago.
5553_3.patch (1.3 KB) - added by Garry Yao 8 years ago.
5554_4.patch (610 bytes) - added by Alfonso Martínez de Lizarrondo 8 years ago.

Download all attachments as: .zip

Change History (21)

Changed 8 years ago by Garry Yao

Attachment: 5553.patch added

comment:1 Changed 8 years ago by Garry Yao

Keywords: Confirmed Review? added
Owner: set to Garry Yao
Status: newassigned
Version: 3.23.0

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Component: GeneralUI : Language
Keywords: Review- added; Review? removed

Considering that the pasting area is there to receive contents to be inputted in the editor, I think the contentsLangDirection setting should be used instead. In that case, the "lang" attribute cannot be used as we don't have such information.

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

#5485 is introducing the contentLanguage setting which could be then used for the "lang" attribute.

comment:4 Changed 8 years ago by Garry Yao

Matches my first thought on this, but does that means we should reflect the same thing to Paste Text dialog?

Changed 8 years ago by Garry Yao

Attachment: 5553_2.patch added

comment:5 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:6 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:7 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [5451].

comment:8 Changed 8 years ago by Satya Minnekanti

Resolution: fixed
Status: closedreopened

This is still not fixed..Cursor is still showing on the left hand side of Text Area in Paste and Paste from Word dialogs.

comment:9 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: reopenedclosed

Now the paste area behaves just like editing document, explicit definition of 'contentsLangDirection' is required if you're using a ltr UI language.

comment:10 Changed 8 years ago by Satya Minnekanti

Resolution: fixed
Status: closedreopened

There is still an inconsistency here. The textarea in the Paste Text dialog is taking the language direction from the UI, it should now use the contentsLangDirection instead.

Changed 8 years ago by Garry Yao

Attachment: 5553_3.patch added

comment:11 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review+ removed

Align the 'Paste Text' area direction.

comment:12 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

The documentation changes may not be needed though, as the pasting area is in fact related to the contents, so it simply inherits its direction (it may happen in other parts of the editor, even if not documented).

comment:13 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: reopenedclosed

Fixed with [5466].

comment:14 Changed 8 years ago by Damian

Resolution: fixed
Status: closedreopened

This still doesn't seem to work for Paste as Plain Text. I can see that the following code is in the dialog:

'dir=' + editor.config.contentsLangDirection + ';' +

but the output HTML does not use the 'dir' property?

Changed 8 years ago by Alfonso Martínez de Lizarrondo

Attachment: 5554_4.patch added

comment:15 Changed 8 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added; Review+ removed

The patch used the "dir=" attribute instead of the css "direction:"

comment:16 Changed 8 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:17 Changed 8 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: reopenedclosed

Fixed with [5507]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy