Opened 8 years ago

Closed 7 years ago

#5565 closed Bug (fixed)

Erratic scrollbar behavior when opening a rich combo with RTL

Reported by: Sa'ar Zac Elias Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.4
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Oracle Cc: Senthil, Pranav

Description

Open a rich combo in an RTL page. Notice that an horizontal scrollbar appears for a short time.
Tested on IE8 and FF3.6.6 with the current trunk. Looks like a regression.

Attachments (3)

5565.patch (1.5 KB) - added by Garry Yao 8 years ago.
5565_2.patch (688 bytes) - added by Garry Yao 7 years ago.
5565_3.patch (1.7 KB) - added by Sa'ar Zac Elias 7 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 8 years ago by Garry Yao

Keywords: Pending added
Milestone: CKEditor 3.3

Works well for me on trunk.

comment:2 Changed 8 years ago by Sa'ar Zac Elias

I can still reproduce it on trunk, but in FF it only happens in the second time or after.
Just notice that I was talking about an RTL page (with <html dir="rtl">), not the direction config.

Changed 8 years ago by Garry Yao

Attachment: 5565.patch added

comment:3 Changed 8 years ago by Garry Yao

Keywords: Confirmed Review? added; Pending removed
Milestone: CKEditor 3.4
Owner: set to Garry Yao
Status: newassigned

Notice that an horizontal scrollbar appears for a short time.

Just to clarify, scrollbar of the host page.

comment:4 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

There are too many unrelated changes in the patch, one of them being even wrong. Just to clarify, the "opacity >= 100" check will never be true now. Let's keep it simple, and make only the necessary changes here.

Changed 7 years ago by Garry Yao

Attachment: 5565_2.patch added

comment:5 Changed 7 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:6 Changed 7 years ago by Frederico Caldeira Knabben

Cc: Senthil Pranav added
Keywords: Oracle added

#5906 has been marked as DUP.

comment:7 Changed 7 years ago by Senthil

After applying the patch, combos are not working but when i only comment the following lines
left : '-3000px',
opacity : '0', FF3 is ignoring "visibility"

and removing the "element.setOpacity( 0 );" line then the reported problem is getting resolved. Can you please check ?

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 5565_3.patch added

comment:8 Changed 7 years ago by Sa'ar Zac Elias

Owner: changed from Garry Yao to Sa'ar Zac Elias
Status: assignednew

I'm having a different approach this time, after all my tests have failed. Instead of hiding the panel by pushing it to the side, I'm pusing it to the top. I've also added some coding style fixes.

comment:9 Changed 7 years ago by Sa'ar Zac Elias

Status: newassigned

comment:10 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:11 Changed 7 years ago by Sa'ar Zac Elias

Fixed with [5686].

comment:12 Changed 7 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy