Opened 7 years ago

Closed 7 years ago

#5623 closed Bug (fixed)

Apply two styles problematic

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.3
Component: Core : Styles Version: 3.2.1
Keywords: Confirmed Firefox Review+ Cc:

Description

Environment

Firefox

Reproducing Procedures

  1. Open the 'replacebyclass' sample page and make the following selection:
    <p>
    	[This is ]some...
    
  2. Apply 'Bold' style on the selected content;
  3. Make the new selection as following and apply 'Italic' Style:
    <p>
    	<strong>This [is ]</strong> some...
    
    • Actual Result: The italic style has expanded onto the previous word.
    • Expected Result: Only the selected content receive the new style.

Attachments (1)

5623.patch (2.0 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Garry Yao

Attachment: 5623.patch added

comment:1 Changed 7 years ago by Garry Yao

Keywords: Review? added
Owner: set to Garry Yao
Status: newassigned

comment:2 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

I remember we've used bookmarks in the past, but for some reason we've changed it to the current code. Maybe we were simply trying to use the original bookmark, while you're proposing creating a new bookmark after enlarging the range.

The change is good, but we must test and watch the style system pretty well before the release.

comment:3 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [5464].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy